You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/07/13 17:38:16 UTC
[GitHub] [incubator-datasketches-website] mkaszas opened a new pull request #93: Fix expanding TOC menus for navigation items
mkaszas opened a new pull request #93:
URL: https://github.com/apache/incubator-datasketches-website/pull/93
https://github.com/apache/incubator-datasketches-website/issues/91
@leerho This fixes the first issue we discussed, by doing 2 things:
- Instead of searching for the first link on the page with a `href` same as the current URL, we search only inside the `#toc`.
- To maintain previous functionality, we're also checking if the top navigation includes a link to the current page, and highlight that link if so.
With this fix in place, there's no need to use any special syntax for the top navigation links or the TOC links, everything will work as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
[GitHub] [incubator-datasketches-website] leerho merged pull request #93: Fix expanding TOC menus for navigation items
Posted by GitBox <gi...@apache.org>.
leerho merged pull request #93:
URL: https://github.com/apache/incubator-datasketches-website/pull/93
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org