You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/07/03 13:27:47 UTC
[GitHub] [netbeans] junichi11 edited a comment on issue #1335:
[NETBEANS-2667] Manage JOptionPane border
junichi11 edited a comment on issue #1335: [NETBEANS-2667] Manage JOptionPane border
URL: https://github.com/apache/netbeans/pull/1335#issuecomment-508091931
@YannLeCorse
> Should I squash nevertheless or should I cancel it and create a new one (with a single commit) ?
No, don't worry :) You can leave this as it is.
That label(Need squashing) is for a person who merges this.
If a PR has some commits and each commit is meaningful and the review was done, the author should squash properly before it is merged, I suppose. In this PR, we need just one commit, so mergers can squash and merge via the Squash and merge button :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists