You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2019/05/22 12:18:14 UTC
[commons-rng] 04/04: JMH annotated classes cannot be final.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 8eb0e210abb365b4a0bd6abc365e39c04b80f1d3
Author: aherbert <ah...@apache.org>
AuthorDate: Wed May 22 13:18:05 2019 +0100
JMH annotated classes cannot be final.
---
.../rng/examples/jmh/NextBooleanGenerationPerformance.java | 2 +-
.../commons/rng/examples/jmh/NextBytesGenerationPerformance.java | 2 +-
.../commons/rng/examples/jmh/NextDoubleGenerationPerformance.java | 2 +-
.../commons/rng/examples/jmh/NextFloatGenerationPerformance.java | 2 +-
.../commons/rng/examples/jmh/NextIntGenerationPerformance.java | 2 +-
.../commons/rng/examples/jmh/NextLongGenerationPerformance.java | 2 +-
src/main/resources/checkstyle/checkstyle-suppressions.xml | 8 +++++---
7 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBooleanGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBooleanGenerationPerformance.java
index e9937eb..5621c8a 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBooleanGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBooleanGenerationPerformance.java
@@ -31,7 +31,7 @@ public class NextBooleanGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextBoolean();
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBytesGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBytesGenerationPerformance.java
index f99aaad..19041c3 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBytesGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextBytesGenerationPerformance.java
@@ -31,7 +31,7 @@ public class NextBytesGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextBytes();
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextDoubleGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextDoubleGenerationPerformance.java
index d917fee..cfa40b2 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextDoubleGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextDoubleGenerationPerformance.java
@@ -31,7 +31,7 @@ public class NextDoubleGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextDouble();
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextFloatGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextFloatGenerationPerformance.java
index 1ad9789..fbd4366 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextFloatGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextFloatGenerationPerformance.java
@@ -31,7 +31,7 @@ public class NextFloatGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextFloat();
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextIntGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextIntGenerationPerformance.java
index 01a825b..5b582b0 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextIntGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextIntGenerationPerformance.java
@@ -32,7 +32,7 @@ public class NextIntGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextInt();
diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextLongGenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextLongGenerationPerformance.java
index 8935dc1..f77fd7f 100644
--- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextLongGenerationPerformance.java
+++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/NextLongGenerationPerformance.java
@@ -32,7 +32,7 @@ public class NextLongGenerationPerformance extends AbstractBenchmark {
* The benchmark state (retrieve the various "RandomSource"s).
*/
@State(Scope.Benchmark)
- public static final class Sources extends BaselineSources {
+ public static class Sources extends BaselineSources {
@Override
protected UniformRandomProvider createBaseline() {
return BaselineUtils.getNextLong();
diff --git a/src/main/resources/checkstyle/checkstyle-suppressions.xml b/src/main/resources/checkstyle/checkstyle-suppressions.xml
index 719b61e..2e182d9 100644
--- a/src/main/resources/checkstyle/checkstyle-suppressions.xml
+++ b/src/main/resources/checkstyle/checkstyle-suppressions.xml
@@ -20,8 +20,10 @@
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
<suppressions>
<!-- Making these final would break API compatibility. -->
- <suppress checks="FinalClass" files="[\\/](ListSampler|InternalGamma|InternalUtils)\.java" />
+ <suppress checks="FinalClass" files="[\\/](ListSampler|InternalGamma|InternalUtils)\.java$" />
<!-- Special cases with many parameters for the constructor. -->
- <suppress checks="ParameterNumber" files="[\\/]LargeMeanPoissonSampler\.java" />
- <suppress checks="ParameterNumber" files="source64[\\/].*XoShiRo512.*\.java" />
+ <suppress checks="ParameterNumber" files="[\\/]LargeMeanPoissonSampler\.java$" />
+ <suppress checks="ParameterNumber" files="source64[\\/].*XoShiRo512.*\.java$" />
+ <!-- JMH annotated classes cannot be final. -->
+ <suppress checks="DesignForExtensionCheck" files="[\\/]Next.*GenerationPerformance\.java$" />
</suppressions>