You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by priyankparihar <gi...@git.apache.org> on 2016/11/24 11:43:21 UTC
[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1775
CLOUDSTACK-9606: While IP address is released, tag are not deleted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9606
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 428f9c6acf8eeddca8fc137e7187bef2d773f7f8
Author: Priyank Parihar <pr...@accelerite.com>
Date: 2016-11-24T11:40:08Z
CLOUDSTACK-9606: While IP address is released, tag are not deleted.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1775#discussion_r90640201
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -168,6 +168,9 @@
import com.cloud.vm.dao.NicSecondaryIpDao;
import com.cloud.vm.dao.UserVmDao;
import com.cloud.vm.dao.VMInstanceDao;
+import com.cloud.server.ResourceTag;
+import com.cloud.tags.dao.ResourceTagDao;
+
--- End diff --
Remove this extra line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1775
can you please provide a description and steps to reproduce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by sarathkouk <gi...@git.apache.org>.
Github user sarathkouk commented on the issue:
https://github.com/apache/cloudstack/pull/1775
[results.txt](https://github.com/apache/cloudstack/files/841130/results.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by priyankparihar <gi...@git.apache.org>.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Hi @rajesh-battala,
Changes are included. Thanks for your careful syntax observation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by priyankparihar <gi...@git.apache.org>.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov and @syed Please take a look. Test case is added. If now everything looks ok then please provide your LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by priyankparihar <gi...@git.apache.org>.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Hi @syed,
>can you please provide a description and steps to reproduce
Please check [CLOUDSTACK-9606](https://issues.apache.org/jira/browse/CLOUDSTACK-9606).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1775#discussion_r90640757
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -281,6 +284,8 @@
VpcDao _vpcDao;
SearchBuilder<IPAddressVO> AssignIpAddressSearch;
SearchBuilder<IPAddressVO> AssignIpAddressFromPodVlanSearch;
+ @Inject
+ ResourceTagDao _resourceTagDao;
--- End diff --
Move 287,288 after 284.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@priyankparihar thank you for adding this test. Have you run it? Since this is not part of the smoketestd can you provide any results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by sarathkouk <gi...@git.apache.org>.
Github user sarathkouk commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Here is the test result,
Test for checking automatic tag removal on released Public IP ... === TestName: test_25_CLOUDSTACK_9606| Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 350.389s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by priyankparihar <gi...@git.apache.org>.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov please trigger smoke test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@priyankparihar can you please add marvin tests and rebase against 4.9 so we could trigger smoke tests and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1775#discussion_r90640403
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -568,6 +573,11 @@ protected boolean cleanupIpResources(long ipId, long userId, Account caller) {
success = false;
}
+ //Remove the tags corresponding to IP.
+ if(success) {
+ _resourceTagDao.removeByIdAndType(ipId, ResourceTag.ResourceObjectType.PublicIpAddress);
+ }
+
--- End diff --
This extra line can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---