You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/07/29 16:06:30 UTC

[PR] fix: pin docker/login-action to an ASF-approved commit SHA [skywalking-eyes]

wu-sheng opened a new pull request, #280:
URL: https://github.com/apache/skywalking-eyes/pull/280

   ### Problem
   
   The `publish-docker` workflow has been failing on every push to `main` with
   `startup_failure` — no jobs ever start, so there is no job log to inspect:
   
   https://github.com/apache/skywalking-eyes/actions/runs/30420520851
   
   ### Cause
   
   `.github/workflows/publish-docker.yaml` referenced a third-party action by
   version tag:
   
   ```yaml
   uses: docker/login-action@v1.10.0
   ```
   
   The [ASF GitHub Actions policy](https://infra.apache.org/github-actions-policy.html)
   requires every third-party action to be pinned to a reviewed **commit SHA** listed in
   [`apache/infrastructure-actions/approved_patterns.yml`](https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml).
   Only the `actions/*`, `apache/*` and `github/*` namespaces are exempt — which is why
   `lint.yaml` and `license-eye-check.yaml` are unaffected. A tag reference is rejected
   before the run starts, hence the startup failure.
   
   This was the only unpinned third-party action left in the repo.
   
   ### Fix
   
   Pin to `650006c6eb7dba73a995cc03b0b2d7f5ca915bee` (`v4.2.0`), which is on the approved
   list and is already the pin used by `skywalking`, `skywalking-java`, `skywalking-cli`,
   `skywalking-go`, `skywalking-python`, `skywalking-horizon-ui` and `skywalking-showcase`.
   
   The v1 → v4 bump is safe for this step: `skywalking-cli` runs the identical step shape
   on this exact pin — same `registry: ${{ env.HUB }}` (a value carrying a path,
   `ghcr.io/apache/...`), same `github.actor` / `GITHUB_TOKEN` credentials.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: pin docker/login-action to an ASF-approved commit SHA [skywalking-eyes]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #280:
URL: https://github.com/apache/skywalking-eyes/pull/280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org