[jira] [Commented] (IMPALA-7487) Failures in stress test when running against minicluster: "int() argument must be a string or a number, not 'NoneType'"

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615031#comment-16615031 ] 

ASF subversion and git services commented on IMPALA-7487:
---------------------------------------------------------

Commit 7793124b6cb7d2e16e7389e59e33cec4963175ad in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=7793124 ]

IMPALA-7487: fix stress test handling of AC memory rejection

The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.

Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.

I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.

Testing:
Ran TPC-H stress test locally, which previous was reliably hitting the
error described in the JIRA.

Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Reviewed-on: http://gerrit.cloudera.org:8080/11432
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: David Knupp <dk...@cloudera.com>


> Failures in stress test when running against minicluster: "int() argument must be a string or a number, not 'NoneType'"
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-7487
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7487
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.1.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>             Fix For: Impala 3.1.0
>
>
> I ran this:
> {code}
> ./tests/stress/concurrent_select.py --tpch-db=tpch_parquet --max-queries 10000 --timeout-multiplier 100 --mem-overcommit-pct 150 --fail-upon-successive-errors=1000
> {code}
> After the binary search succeeds lots of queries fail with this error:
> {noformat}
> Process Process-39:
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
>     self.run()
>   File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
>     self._target(*self._args, **self._kwargs)
>   File "./tests/stress/concurrent_select.py", line 703, in _start_single_runner
>     if should_cancel:
> TypeError: int() argument must be a string or a number, not 'NoneType'
>     func(*targs, **kargs)
>   File "/usr/lib/python2.7/multiprocessing/util.py", line 328, in _exit_function
>     _run_finalizers()
>   File "/usr/lib/python2.7/multiprocessing/util.py", line 274, in _run_finalizers
>     finalizer()
>   File "/usr/lib/python2.7/multiprocessing/util.py", line 207, in __call__
>     res = self._callback(*self._args, **self._kwargs)
>   File "/usr/lib/python2.7/multiprocessing/queues.py", line 218, in _finalize_join
>     thread.join()
>   File "/usr/lib/python2.7/threading.py", line 940, in join
>     self.__block.wait()
>   File "/usr/lib/python2.7/threading.py", line 340, in wait
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org