You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/02/24 05:23:59 UTC
[GitHub] spark pull request #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/17050
[SPARK-19722] [SQL] [MINOR] Clean up the usage of EliminateSubqueryAliases
### What changes were proposed in this pull request?
In the PR https://github.com/apache/spark/pull/11403, we introduced the function `canonicalized` for eliminating useless subqueries. We can simply replace the call of rule `EliminateSubqueryAliases` by the function `canonicalized`.
After we changed the view resolution and management, the current reason why we keep `EliminateSubqueryAliases ` in optimizer becomes out-of-dated. Thus, this PR also update the reason to `eager analysis of Dataset`.
### How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark eliminateSubquery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17050.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17050
----
commit d75b94c1abb4b60444a4191319c787a50a061bf9
Author: Xiao Li <ga...@gmail.com>
Date: 2017-02-24T05:08:02Z
fix.
commit 3cde705c6baa1e4a869149f3ca289a5c1e3a3000
Author: Xiao Li <ga...@gmail.com>
Date: 2017-02-24T05:23:05Z
clean
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/17050
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of Elimin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17050
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of Elimin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17050
**[Test build #73397 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73397/testReport)** for PR 17050 at commit [`3cde705`](https://github.com/apache/spark/commit/3cde705c6baa1e4a869149f3ca289a5c1e3a3000).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of Elimin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17050
**[Test build #73397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73397/testReport)** for PR 17050 at commit [`3cde705`](https://github.com/apache/spark/commit/3cde705c6baa1e4a869149f3ca289a5c1e3a3000).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17050: [SPARK-19722] [SQL] [MINOR] Clean up the usage of Elimin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73397/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org