[GitHub] [doris] morrySnow commented on a diff in pull request #19926: [fix](DECIMALV3) Fix the error in DECIMALV3 when explicitly casting.

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #19926:
URL: https://github.com/apache/doris/pull/19926#discussion_r1201443761


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -284,6 +284,11 @@ public boolean apply(Expr arg) {
     // Needed for properly capturing expr precedences in the SQL string.
     protected boolean printSqlInParens = false;
 
+    // The code is used to distinguish whether an expression is explicitly cast or
+    // not. For example, different treatments should be applied to a computed value
+    // of 1.000 and a value of 1.000 obtained through casting.
+    protected boolean isCasted = false;

Review Comment:
   should set back to default value in `reset()` function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org