Re: [PR] UI: Proper explanation for the global setting to avoid ambiguity [cloudstack]

["nvazquez (via GitHub)" <gi...@apache.org>]

nvazquez commented on code in PR #10042:
URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1954345205


##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -1397,9 +1397,10 @@ private void processHostHealthCheckResult(Boolean hostHealthCheckResult, long ho
                 logger.error("Unable to find host with ID: {}", hostId);
                 return;
             }
+

Review Comment:
   Can we revert changes on this file?



##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -1840,9 +1840,9 @@ private void handleAutoEnableDisableKVMHost(boolean autoEnableDisableKVMSetting,
                 _hostDetailsDao.update(hostDetail.getId(), hostDetail);
             } else if (!isUpdateFromHostHealthCheck && hostDetail != null &&
                     Boolean.parseBoolean(hostDetail.getValue()) && resourceEvent == ResourceState.Event.Disable) {
-                logger.info(String.format("The setting %s is enabled but the host %s is manually set into %s state," +
+                logger.info("The setting {} is enabled but the host {} is manually set into {} state," +

Review Comment:
   And this file also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org