You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by Clarkkkkk <gi...@git.apache.org> on 2018/07/02 08:59:43 UTC

[GitHub] flink pull request #6237: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

GitHub user Clarkkkkk opened a pull request:

    https://github.com/apache/flink/pull/6237

    [FLINK-9567][runtime][yarn] Fix the bug that Flink does not release YarnContainer in some cases

    ## What is the purpose of the change
    
      - This pull request responds to  [JIRA issue FLINK-9567](https://issues.apache.org/jira/browse/FLINK-9567). 
      
      - This pull request is to avoid flink system from not releasing excessive container when Yarn Callback onContainerCompleted was called after a full restart.
    
    ## Brief change log
    
      - Modify the onContainerCompleted method in YarnResourceManager.
    
     - Add a getNumberPendingSlotRequests in SlotManager that check how many pending slot requests are not fulfilled
    
      - Add a getNumberPendingSlotRequests in ResourceManager that get pending slot requests from SlotManager
    
    ## Verifying this change
    This  change is covered by testOnContainerCompleted added in YarnResourceManagerTest
    
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
    
      - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
    
      - The serializers: (no)
    
      - The runtime per-record code paths (performance sensitive): (no)
    
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
    
      - The S3 file system connector: (no)
    
    ## Documentation
      - Does this pull request introduce a new feature? (No)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Clarkkkkk/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6237
    
----
commit 92086f1c56d9d170619fae170aed092e075c7c63
Author: yangshimin <ya...@...>
Date:   2018-07-02T03:56:00Z

    [FLINK-9567][runtime][yarn] Fix the bug that Flink does not release Yarn container when onContainerCompleted callback method happened after full restart
    
    a
    
    [FLINK-9567][runtime][yarn] Fix the bug that Flink does not release Yarn container when onContainerCompleted callback method happened after full restart

----


---

[GitHub] flink issue #6237: [FLINK-9567][runtime][yarn] Fix the bug that Flink does n...

Posted by Clarkkkkk <gi...@git.apache.org>.

Github user Clarkkkkk commented on the issue:

    https://github.com/apache/flink/pull/6237
  
    @tillrohrmann Hi Till, I fix this bug according to the idea you mentioned on last conversation we had.


---

[GitHub] flink pull request #6237: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6237


---