You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2011/11/22 09:42:40 UTC

[jira] [Created] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Unit test are hanging on 0.8 branch
-----------------------------------

                 Key: CASSANDRA-3520
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
             Project: Cassandra
          Issue Type: Bug
          Components: Tests
         Environment: Linux
            Reporter: Sylvain Lebresne
             Fix For: 0.8.8


As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155205#comment-13155205 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

On Windows CliTest on 0.8 times out, after all the tests pass, but it does not hang.
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158324#comment-13158324 ] 

Sylvain Lebresne commented on CASSANDRA-3520:
---------------------------------------------

I was a bit fast at calling it victory. I was testing with CleanupTest that was hanging as well, and starting from the same revision, so I assumed that the problem was the exact same as for CliTest. Turns out setting durable writes does fix both CleanupTest and AntiEntropyServiceCounterTest, but CliTest is still hanging (it's now the only one to do so however).
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155148#comment-13155148 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

Does it hang if you just run CliTest, or only for the whole suite?
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157248#comment-13157248 ] 

Hudson commented on CASSANDRA-3520:
-----------------------------------

Integrated in Cassandra-0.8 #406 (See [https://builds.apache.org/job/Cassandra-0.8/406/])
    set system keyspace back to durable_writes
patch by slebresne; reviewed by jbellis for CASSANDRA-3520

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206257
Files : 
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/config/KSMetaData.java

                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158465#comment-13158465 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

+1, but can we add a system test w/ a non-durable ks to help prevent regressions?
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch, 3520.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-3520:
----------------------------------------

    Attachment: 0001-Use-durable-writes-for-system-ks.patch

So, some form of progress here. The hanging can be bisected to r1185961 (svn). And it is actually due to the switch to non-durable writes for the system keyspace. But I don't know why yet. In particular 1.0 and trunk also use non-durable writes and have no such problem.

I'm attaching a small patch to re-enable durable writes. I think we should figure out what is going on, but if we want to go ahead with the release of 0.8.8 in the meantime, we could apply that.

Last info, CliTest is not the only one to hang, CleanupTest and AntiEntropyServiceCounterTest.java are also hanging.

                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-3520:
----------------------------------------

    Attachment: 3520.patch

So, the whole problem is due to our handling of non durable writes in the shutdown hook. For those, we flush the CFS as part of shutdown. However, flush tries to grab a commitlog context, which blocks because the commit log has been shutdown *before* all this (and for some reason, executor.submit() don't throw any exception if the executor is shutdown).

The reason why r1185960 was triggering this is that it actually fixed a bug by which previously to this commit, adding a new column family to a keyspace would reset the durableWrites option to true, hence hiding the bug as far as CliTest is concerned.

One simple solution is to move the commit log shutdown after the flushes of the non-durable CFs (which 1.0 does, and that's why it isn't affected). Truth is, it doesn't feel like the right fix in that non-durable CF shouldn't query the commit log at all, even during flushes. However, changing that introduces the possibility to have some CL segment retained forever when upgrading a keyspace from non-durable to durable if we're not careful. So overall just pushing the CL shutdown down in the shutdown hook to match 1.0 seems good enough, at least for 0.8. Attaching a patch to do just that. We can then look at making things cleaner with respect to flushing non-durable CFS in 1.0/trunk if we so wish.

Note that while having a non-durable system keyspace was not directly the problem, I think it was a fairly bad idea, and we should leave it to durable for 0.8 and turn it back to durable for 1.0 and trunk.

                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch, 3520.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155153#comment-13155153 ] 

Sylvain Lebresne commented on CASSANDRA-3520:
---------------------------------------------

Only CliTest. I honestly didn't really try to run other tests (and CliTest is like the 3rd test), so possibly there is other tests failing.
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158465#comment-13158465 ] 

Jonathan Ellis edited comment on CASSANDRA-3520 at 11/28/11 2:29 PM:
---------------------------------------------------------------------

+1, but can we add a system test w/ a non-durable ks to help prevent regressions?

Edit: never mind, that's what we're already doing in NoCommitlogSpace, hence the continuing clitest timeout
                
      was (Author: jbellis):
    +1, but can we add a system test w/ a non-durable ks to help prevent regressions?
                  
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch, 3520.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157263#comment-13157263 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

I can confirm that r1185960 is the last revision that doesn't timeout CliTest.  (r1185961 doesn't compile, and r1185963 times out.)
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158506#comment-13158506 ] 

Hudson commented on CASSANDRA-3520:
-----------------------------------

Integrated in Cassandra-0.8 #407 (See [https://builds.apache.org/job/Cassandra-0.8/407/])
    Shutdown CL after having flushed non-durable CF
patch by slebresne; reviewed by jbellis for CASSANDRA-3520

slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207262
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java

                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch, 3520.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne resolved CASSANDRA-3520.
-----------------------------------------

    Resolution: Fixed
      Reviewer: jbellis
      Assignee: Sylvain Lebresne

Committed
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch, 3520.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157211#comment-13157211 ] 

Sylvain Lebresne commented on CASSANDRA-3520:
---------------------------------------------

btw, how sure are we that using non-durable writes for the system keyspace is a good idea? It doesn't seem great for hints at least. Moreover on 1.0, when will the CF be flushed if durable_writes is false unless we do a manual flush?
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157235#comment-13157235 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

Setting durable_writes back to true does not fix CliTest timing out on windows.  However, I can't think a good reason to have it off for the system KS so I committed 0001.
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>         Attachments: 0001-Use-durable-writes-for-system-ks.patch
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3520) Unit test are hanging on 0.8 branch

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155206#comment-13155206 ] 

Jonathan Ellis commented on CASSANDRA-3520:
-------------------------------------------

(My 0.8 checkout was on the 0.8.6 tag when I reported that CliTest worked completely.)
                
> Unit test are hanging on 0.8 branch
> -----------------------------------
>
>                 Key: CASSANDRA-3520
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3520
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>         Environment: Linux
>            Reporter: Sylvain Lebresne
>             Fix For: 0.8.8
>
>
> As the summary says, the unit test on current 0.8 are just hanging after CliTest (it's apparently not the case on windows, but it is on Linux and MacOSX).
> Not sure what's going on, but what I can tell is that it's enough to run CliTest to have it hang after the test successfully pass (i.e, JUnit just wait indefinitely for the VM to exit). Even weirder, it seems that it is the counter increment in the CliTest that make it hang, if you comment those statement, it stop hanging. However, nothing seems to go wrong with the increment itself (the test passes) and it doesn't even trigger anything (typically sendToHintedEndpoint is not called because there is only one node).
> Looking at the stack when the VM is hanging (attached), there is nothing specific to counters in there, and nothing that struck me at odd (but I could miss something). There do is a few thrift thread running (CASSANDRA-3335), but why would that only be a problem for the tests in that situation is a mystery to me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira