You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/04 04:31:09 UTC
[GitHub] [rocketmq] codecov-io commented on pull request #2400: fix SelectMessageQueueByHash in case hashcode is Integer.MIN
codecov-io commented on pull request #2400:
URL: https://github.com/apache/rocketmq/pull/2400#issuecomment-721505795
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=h1) Report
> Merging [#2400](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/77d24def3a5aafd0d10afd525734bba398cf48b2?el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2400 +/- ##
=============================================
+ Coverage 45.69% 45.73% +0.03%
- Complexity 4289 4296 +7
=============================================
Files 547 547
Lines 35971 36030 +59
Branches 4770 4783 +13
=============================================
+ Hits 16437 16477 +40
- Misses 17477 17481 +4
- Partials 2057 2072 +15
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nt/producer/selector/SelectMessageQueueByHash.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvc2VsZWN0b3IvU2VsZWN0TWVzc2FnZVF1ZXVlQnlIYXNoLmphdmE=) | `100.00% <100.00%> (+33.33%)` | `3.00 <2.00> (+1.00)` | |
| [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-8.96%)` | `16.00% <0.00%> (-3.00%)` | |
| [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `75.00% <0.00%> (-7.70%)` | `10.00% <0.00%> (-1.00%)` | |
| [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | `16.00% <0.00%> (-2.00%)` | |
| [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.86% <0.00%> (-4.06%)` | `20.00% <0.00%> (-2.00%)` | |
| [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `50.42% <0.00%> (-0.86%)` | `12.00% <0.00%> (-1.00%)` | |
| [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `67.88% <0.00%> (-0.67%)` | `18.00% <0.00%> (ø%)` | |
| [...pache/rocketmq/store/dledger/DLedgerCommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2RsZWRnZXIvRExlZGdlckNvbW1pdExvZy5qYXZh) | `72.33% <0.00%> (-0.64%)` | `57.00% <0.00%> (+8.00%)` | :arrow_down: |
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.09% <0.00%> (-0.54%)` | `24.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/rocketmq/pull/2400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=footer). Last update [77d24de...1681e3d](https://codecov.io/gh/apache/rocketmq/pull/2400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org