You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by mc...@apache.org on 2017/06/09 10:24:14 UTC
svn commit: r1798185 - in
/jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend: ./
SamplerMetricTest.java
Author: mchassagneux
Date: Fri Jun 9 10:24:14 2017
New Revision: 1798185
URL: http://svn.apache.org/viewvc?rev=1798185&view=rev
Log:
Add JUnit test for SamplerMetric
Added:
jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/
jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java (with props)
Added: jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java?rev=1798185&view=auto
==============================================================================
--- jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java (added)
+++ jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java Fri Jun 9 10:24:14 2017
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.jmeter.visualizers.backend;
+
+import static org.junit.Assert.assertEquals;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
+
+import org.apache.jmeter.samplers.SampleResult;
+import org.junit.Test;
+
+public class SamplerMetricTest {
+
+ private static final int DEFAULT_ELAPSED_TIME = 1_000;
+
+ /**
+ * Method to change a static final field
+ * @param field
+ * @param newValue
+ * @throws Exception
+ */
+ static void setFinalStatic(Field field, Object newValue) throws Exception {
+ field.setAccessible(true);
+ Field modifiersField = Field.class.getDeclaredField("modifiers");
+ modifiersField.setAccessible(true);
+ modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);
+ field.set(null, newValue);
+ }
+
+ @Test
+ public void checkResetOkAndAllStats() throws NoSuchFieldException, SecurityException, Exception {
+ setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.FIXED);
+ SamplerMetric metric = new SamplerMetric();
+ metric.add(createSampleResult(true));
+ assertEquals("Before reset ok.max", DEFAULT_ELAPSED_TIME, metric.getOkMaxTime() , 0.001);
+ assertEquals("Before reset all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.001);
+ assertEquals("Before reset failure", 1, metric.getHits(), 0.0);
+
+ // In fixed mode DescriptiveStatistics are not reset, just sliding on a window
+ metric.resetForTimeInterval();
+
+ assertEquals("After reset in FIXED mode ok.max", DEFAULT_ELAPSED_TIME, metric.getOkMaxTime() , 0.0);
+ assertEquals("After reset in FIXED mode all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.0);
+ assertEquals("After reset failure", 0, metric.getHits(), 0.0);
+
+ // Change mode to TIMED, now all metric are reset on each interval
+ setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.TIMED);
+ metric.resetForTimeInterval();
+
+ assertEquals("After reset in TIMED mode ok.max", Double.NaN, metric.getOkMaxTime() , 0.0);
+ assertEquals("After reset in TIMED mode all.max", Double.NaN, metric.getAllMaxTime(), 0.0);
+
+ }
+
+ @Test
+ public void checkResetKoAndAllStats() throws NoSuchFieldException, SecurityException, Exception {
+
+ setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.FIXED);
+ SamplerMetric metric = new SamplerMetric();
+ metric.add(createSampleResult(false));
+ assertEquals("Before reset ko.max", DEFAULT_ELAPSED_TIME, metric.getKoMaxTime() , 0.001);
+ assertEquals("Before reset all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.001);
+ assertEquals("Before reset failure", 1, metric.getFailures(), 0.0);
+
+ // In fixed mode DescriptiveStatistics are not reset, just sliding on a window
+ metric.resetForTimeInterval();
+
+ assertEquals("After reset in FIXED mode ko.max", DEFAULT_ELAPSED_TIME, metric.getKoMaxTime() , 0.0);
+ assertEquals("After reset in FIXED mode all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.0);
+ assertEquals("After reset failure", 0, metric.getFailures(), 0.001);
+
+ // Change mode to TIMED, now all metric are reset on each interval
+ setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.TIMED);
+ metric.resetForTimeInterval();
+
+ assertEquals("After reset in TIMED mode ko.max", Double.NaN, metric.getKoMaxTime() , 0.0);
+ assertEquals("After reset in TIMED mode all.max", Double.NaN, metric.getAllMaxTime(), 0.0);
+ }
+
+
+ @Test
+ public void checkErrorsDetailStat() {
+
+ SamplerMetric metric = new SamplerMetric();
+ metric.add(createSampleResult("400", "bad request"));
+ metric.add(createSampleResult("400", "Bad Request "));
+ metric.add(createSampleResult("500", "Internal Server Error"));
+ ErrorMetric error = new ErrorMetric( createSampleResult("400", "Bad request") );
+ assertEquals("Count for '400 - bad request' error ", 2, metric.getErrors().get(error) , 0.0);
+ error = new ErrorMetric( createSampleResult("500", "Internal Server Error") );
+ assertEquals("Count for '500 - Internal Server Error' error ", 1, metric.getErrors().get(error) , 0.0);
+
+ }
+
+ private SampleResult createSampleResult(boolean success) {
+ SampleResult result = new SampleResult();
+ result.setSuccessful(success);
+ result.setSampleCount(1);
+ result.setErrorCount(success ? 0 : 1);
+ result.sampleStart();
+ result.setEndTime(result.getStartTime() + DEFAULT_ELAPSED_TIME);
+ return result;
+ }
+
+ private SampleResult createSampleResult(String errorCode, String errorMessage) {
+ SampleResult result = createSampleResult(false);
+ result.setResponseCode(errorCode);
+ result.setResponseMessage(errorMessage);
+ return result;
+ }
+}
Propchange: jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java
------------------------------------------------------------------------------
svn:eol-style = native
Re: svn commit: r1798185 - in
/jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend: ./
SamplerMetricTest.java
Posted by Felix Schumacher <fe...@internetallee.de>.
Hi Maxime,
a few notes below
Am 09.06.2017 um 12:24 schrieb mchassagneux@apache.org:
> Author: mchassagneux
> Date: Fri Jun 9 10:24:14 2017
> New Revision: 1798185
>
> URL: http://svn.apache.org/viewvc?rev=1798185&view=rev
> Log:
> Add JUnit test for SamplerMetric
>
> Added:
> jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/
> jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java (with props)
>
> Added: jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java?rev=1798185&view=auto
> ==============================================================================
> --- jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java (added)
> +++ jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java Fri Jun 9 10:24:14 2017
> @@ -0,0 +1,128 @@
...
> +
> +package org.apache.jmeter.visualizers.backend;
> +
> +import static org.junit.Assert.assertEquals;
> +
> +import java.lang.reflect.Field;
> +import java.lang.reflect.Modifier;
> +
> +import org.apache.jmeter.samplers.SampleResult;
> +import org.junit.Test;
> +
> +public class SamplerMetricTest {
> +
> + private static final int DEFAULT_ELAPSED_TIME = 1_000;
> +
> + /**
> + * Method to change a static final field
> + * @param field
> + * @param newValue
> + * @throws Exception
> + */
> + static void setFinalStatic(Field field, Object newValue) throws Exception {
> + field.setAccessible(true);
> + Field modifiersField = Field.class.getDeclaredField("modifiers");
> + modifiersField.setAccessible(true);
> + modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);
> + field.set(null, newValue);
> + }
> +
> + @Test
> + public void checkResetOkAndAllStats() throws NoSuchFieldException, SecurityException, Exception {
> + setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.FIXED);
Is this really needed, given that WindowMode.get() uses the property
"backend_metrics_window_mode" that can be set with JMeterUtils.setProperty.
> + SamplerMetric metric = new SamplerMetric();
> + metric.add(createSampleResult(true));
> + assertEquals("Before reset ok.max", DEFAULT_ELAPSED_TIME, metric.getOkMaxTime() , 0.001);
> + assertEquals("Before reset all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.001);
Comparisons with float values should probably better be coded with a
margin to guard against rounding problems. But note, that I haven't
looked further into this.
> + assertEquals("Before reset failure", 1, metric.getHits(), 0.0);
> +
> + // In fixed mode DescriptiveStatistics are not reset, just sliding on a window
> + metric.resetForTimeInterval();
> +
> + assertEquals("After reset in FIXED mode ok.max", DEFAULT_ELAPSED_TIME, metric.getOkMaxTime() , 0.0);
> + assertEquals("After reset in FIXED mode all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.0);
> + assertEquals("After reset failure", 0, metric.getHits(), 0.0);
> +
> + // Change mode to TIMED, now all metric are reset on each interval
Is this a real use case? I would not expect properties to change at
runtime (at least not under normal circumstances). I think the fixed and
windowed mode should be coded in two different test methods.
> + setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.TIMED);
> + metric.resetForTimeInterval();
> +
> + assertEquals("After reset in TIMED mode ok.max", Double.NaN, metric.getOkMaxTime() , 0.0);
> + assertEquals("After reset in TIMED mode all.max", Double.NaN, metric.getAllMaxTime(), 0.0);
> +
> + }
> +
> + @Test
> + public void checkResetKoAndAllStats() throws NoSuchFieldException, SecurityException, Exception {
> +
> + setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.FIXED);
> + SamplerMetric metric = new SamplerMetric();
> + metric.add(createSampleResult(false));
> + assertEquals("Before reset ko.max", DEFAULT_ELAPSED_TIME, metric.getKoMaxTime() , 0.001);
> + assertEquals("Before reset all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.001);
> + assertEquals("Before reset failure", 1, metric.getFailures(), 0.0);
> +
> + // In fixed mode DescriptiveStatistics are not reset, just sliding on a window
> + metric.resetForTimeInterval();
> +
> + assertEquals("After reset in FIXED mode ko.max", DEFAULT_ELAPSED_TIME, metric.getKoMaxTime() , 0.0);
> + assertEquals("After reset in FIXED mode all.max", DEFAULT_ELAPSED_TIME, metric.getAllMaxTime(), 0.0);
> + assertEquals("After reset failure", 0, metric.getFailures(), 0.001);
> +
> + // Change mode to TIMED, now all metric are reset on each interval
> + setFinalStatic(SamplerMetric.class.getDeclaredField("WINDOW_MODE"), WindowMode.TIMED);
> + metric.resetForTimeInterval();
> +
> + assertEquals("After reset in TIMED mode ko.max", Double.NaN, metric.getKoMaxTime() , 0.0);
> + assertEquals("After reset in TIMED mode all.max", Double.NaN, metric.getAllMaxTime(), 0.0);
> + }
> +
> +
> + @Test
> + public void checkErrorsDetailStat() {
> +
> + SamplerMetric metric = new SamplerMetric();
> + metric.add(createSampleResult("400", "bad request"));
> + metric.add(createSampleResult("400", "Bad Request "));
> + metric.add(createSampleResult("500", "Internal Server Error"));
> + ErrorMetric error = new ErrorMetric( createSampleResult("400", "Bad request") );
> + assertEquals("Count for '400 - bad request' error ", 2, metric.getErrors().get(error) , 0.0);
> + error = new ErrorMetric( createSampleResult("500", "Internal Server Error") );
> + assertEquals("Count for '500 - Internal Server Error' error ", 1, metric.getErrors().get(error) , 0.0);
> +
> + }
> +
> + private SampleResult createSampleResult(boolean success) {
> + SampleResult result = new SampleResult();
> + result.setSuccessful(success);
> + result.setSampleCount(1);
> + result.setErrorCount(success ? 0 : 1);
> + result.sampleStart();
> + result.setEndTime(result.getStartTime() + DEFAULT_ELAPSED_TIME);
> + return result;
> + }
> +
> + private SampleResult createSampleResult(String errorCode, String errorMessage) {
> + SampleResult result = createSampleResult(false);
> + result.setResponseCode(errorCode);
> + result.setResponseMessage(errorMessage);
> + return result;
> + }
> +}
>
> Propchange: jmeter/trunk/test/src/org/apache/jmeter/visualizers/backend/SamplerMetricTest.java
> ------------------------------------------------------------------------------
> svn:eol-style = native
>
>