[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2892: ARTEMIS-2549 - Add Downstream support to Federation

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2892: ARTEMIS-2549 - Add Downstream support to Federation
URL: https://github.com/apache/activemq-artemis/pull/2892#discussion_r346685809
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/config/federation/FederationStreamConfiguration.java
 ##########
 @@ -33,7 +35,7 @@ public String getName() {
       return name;
    }
 
-   public FederationUpstreamConfiguration setName(String name) {
+   public FederationStreamConfiguration setName(String name) {
 
 Review comment:
   Can you make the class <T extends FederationStreamConfiguration> and then here, and other returns, return T, this then mans when its returned you get the correct type, which would have any extra setters or getters. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services