[jira] [Updated] (OAK-7231) Remove PermissionEntryCache.getNumEntries

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-7231:
------------------------
    Attachment: OAK-7231.patch

> Remove PermissionEntryCache.getNumEntries
> -----------------------------------------
>
>                 Key: OAK-7231
>                 URL: https://issues.apache.org/jira/browse/OAK-7231
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: OAK-7231.patch
>
>
> [~stillalex], i looks to me that {{PermissionEntryCache.getNumEntries}} is redundant and the single place where it is called could be replaced by {{PermissionStore.getNumEntries}}.
> here is why: the method is only call upon {{PermissionEntryProviderImpl.init}}, which itself is only called if the cache is still empty or if it just has been flushed.
> while i don't see an immediate drawback of the method itself, it would IMO improve readability and clarity. 
> but i definitely want to wait for your review and ok in order to make sure, i don't miss something fundamental in such a key area of the permission evaluation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)