You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/15 08:05:52 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #7454: Add more test cases for BackendConnection
terrymanu opened a new issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454
- [ ] getConnections with getConnectionsWithoutTransaction
- [ ] createStorageResource
- [ ] setFetchSize
- [ ] isSerialExecute
- [ ] add
- [ ] closeResultSets
- [ ] closeStatements
- [ ] closeConnections
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
sluk3r commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-693103584
> May ignore for some checkstyle checks
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
sluk3r commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-692732795
And in ShardingSphere community, what is common solutions for ClassFanOutComplexity? need help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
sluk3r commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-693345300
@terrymanu for task of setFetchSize and add, test cases are added also, the following is the details:
1. test case for method of add are: assertAddStatementCorrectly, assertAddResultSetCorrectly
2. test case for method of setFetchSize is assertSetFetchSizeAsExpected
Please check the result
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
sluk3r commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-692728907
before adding test code, I do checkstyle, result is:
So, should I solve this style problem as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
sluk3r commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-692696322
please assign it to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454#issuecomment-692803913
May ignore for some checkstyle checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #7454: Add more test cases for BackendConnection
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #7454:
URL: https://github.com/apache/shardingsphere/issues/7454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org