You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ambud Sharma <am...@gmail.com> on 2013/06/03 23:26:58 UTC
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n
characters by SyslogUtils.extractEvent() function
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9842/
-----------------------------------------------------------
(Updated June 3, 2013, 9:26 p.m.)
Review request for Flume.
Changes
-------
Diff with unit test and TCP compliance
Description
-------
Ref: https://issues.apache.org/jira/browse/FLUME-1938
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
Diff: https://reviews.apache.org/r/9842/diff/
Testing
-------
Functional test done resulting in full message body being written to file.
Thanks,
Ambud Sharma
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n
characters by SyslogUtils.extractEvent() function
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9842/#review21613
-----------------------------------------------------------
Ship it!
Thanks for finding and fixing the SyslogTCP issue. Looks good to me.
- Alexander Alten-Lorenz
On June 3, 2013, 9:41 p.m., Ambud Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9842/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 9:41 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Ref: https://issues.apache.org/jira/browse/FLUME-1938
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
>
> Diff: https://reviews.apache.org/r/9842/diff/
>
>
> Testing
> -------
>
> Functional test done resulting in full message body being written to file.
>
>
> Thanks,
>
> Ambud Sharma
>
>
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n
characters by SyslogUtils.extractEvent() function
Posted by Ambud Sharma <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9842/
-----------------------------------------------------------
(Updated June 3, 2013, 9:41 p.m.)
Review request for Flume.
Description
-------
Ref: https://issues.apache.org/jira/browse/FLUME-1938
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
Diff: https://reviews.apache.org/r/9842/diff/
Testing
-------
Functional test done resulting in full message body being written to file.
Thanks,
Ambud Sharma
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n
characters by SyslogUtils.extractEvent() function
Posted by Ambud Sharma <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9842/
-----------------------------------------------------------
(Updated June 3, 2013, 9:38 p.m.)
Review request for Flume.
Changes
-------
Spaces fix
Description
-------
Ref: https://issues.apache.org/jira/browse/FLUME-1938
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
Diff: https://reviews.apache.org/r/9842/diff/
Testing
-------
Functional test done resulting in full message body being written to file.
Thanks,
Ambud Sharma