You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2025/04/10 08:22:16 UTC

[PR] [fix][test] Fix invalid test CompactionTest.testDeleteCompactedLedgerWithSlowAck [pulsar]

lhotari opened a new pull request, #24166:
URL: https://github.com/apache/pulsar/pull/24166

   ### Motivation
   
   The test CompactionTest.testDeleteCompactedLedgerWithSlowAck fails with PR #23980. The test appears to be invalid and needs to be revisited.
   
   ### Modifications
   
   - revisit CompactionTest.testDeleteCompactedLedgerWithSlowAck
   - replace the usage of long deprecated topic naming format where the cluster name is part of the topic name
     - this format is not compatible with topic policies
   - improve the CompactionTest test class by doing some other cleanup such are using static imports for assertion methods.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix invalid test CompactionTest.testDeleteCompactedLedgerWithSlowAck [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24166:
URL: https://github.com/apache/pulsar/pull/24166#issuecomment-2792218936

   > LGTM.  However, this PR changes the topic name format from v1 to v2, which I am concerned will cause a conflict when cherry-picking this PR to the maintenance branches.
   > 
   > Would make sense that create a new PR to improve that?
   
   It was necessary to change to v2 for the single test case so that topic policies can be used. Topic policies fail with v1 topics. Because of consistency, I changed the complete test class to use v2 topic format.
   
   @nodece I can handle resolving merge conflicts while cherry-picking, so no need to worry about that. I have a pretty good workflow for merge conflict resolution so that's not a big problem in this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][test] Fix invalid test CompactionTest.testDeleteCompactedLedgerWithSlowAck [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #24166:
URL: https://github.com/apache/pulsar/pull/24166


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org