[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #1791: Disruptor native support

[GitBox <gi...@apache.org>]

davsclaus commented on a change in pull request #1791:
URL: https://github.com/apache/camel-quarkus/pull/1791#discussion_r488482307



##########
File path: extensions/disruptor/runtime/pom.xml
##########
@@ -57,6 +57,11 @@
             <groupId>org.apache.camel</groupId>
             <artifactId>camel-disruptor</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.graalvm.nativeimage</groupId>
+            <artifactId>svm</artifactId>
+            <scope>provided</scope>        </dependency>

Review comment:
       Tidy up

##########
File path: extensions/disruptor/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -24,9 +24,8 @@
 name: "Camel Disruptor"
 description: "Provides asynchronous SEDA behavior using LMAX Disruptor"
 metadata:
-  unlisted: true
   guide: "https://camel.apache.org/camel-quarkus/latest/reference/extensions/disruptor.html"
   categories:
   - "integration"
   status:
-  - "preview"
+  - "stable"

Review comment:
       Is it really stable when we just landed native support?

##########
File path: extensions/disruptor/runtime/pom.xml
##########
@@ -87,6 +92,8 @@
                             <version>${quarkus.version}</version>
                         </path>
                     </annotationProcessorPaths>
+                    <source>9</source>

Review comment:
       Should this not be 11 instead of 9 if we go higher than 8




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org