You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by mravi <gi...@git.apache.org> on 2015/11/01 05:05:59 UTC

[GitHub] sqoop pull request: phoenix integration with 1.4.6

GitHub user mravi opened a pull request:

    https://github.com/apache/sqoop/pull/10

    phoenix integration with 1.4.6

    This PR contains a code patch for importing data into Apache Phoenix tables from SQL.  
    The following tasks are pending
    a) Unit Tests. As the third party tests related to HBase are failing on a fresh checkout from GIT , I couldn't complete writing all the tests.
    b) Code Template format. Are there any specific Eclipse Code Template Formats that I should be configuring .
    c) Right now the code is built against 1.4.6 v of Sqoop as we have seen users requesting for Sqoop support in Phoenix mailing list. Based on the comments and feedback, I will come up with a patch against master branches. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mravi/sqoop branch-1.4.6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sqoop/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit c33f779e5c7731e52214c885c33ca0901935411b
Author: ravimagham <ra...@apache.org>
Date:   2015-10-26T08:23:24Z

    scoop phoenix first code drop

commit de739925d10641e091350469a656ea7b64de82b9
Author: ravimagham <ra...@apache.org>
Date:   2015-11-01T03:55:07Z

    code drop for bulk load onto phoenix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] sqoop pull request: phoenix integration with 1.4.6

Posted by ravimagham <gi...@git.apache.org>.

Github user ravimagham commented on the pull request:

    https://github.com/apache/sqoop/pull/10#issuecomment-155887939
  
    Thanks Gabriel Reid. I will make the necessary corrections and have the patch updated to the ticket and open a RB. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] sqoop pull request: phoenix integration with 1.4.6

Posted by gabrielreid <gi...@git.apache.org>.

Github user gabrielreid commented on the pull request:

    https://github.com/apache/sqoop/pull/10#issuecomment-155878871
  
    Just taking a look through this -- having Phoenix support in Sqoop would be great!
    
    I know that this is an initial cut, but just a few remarks on the code:
    * Around code style:
      * it looks like the general Sqoop convention is to use 2 spaces for indentation, but this code uses 4 spaces
      * the Sqoop code includes a space after an `if` and before the opening parenthesis, but this code omits that space
    * The `PhoenixImportJob` class extends the `DataDrivenImportJob` class in the `com.cloudera.sqoop` package, but this is deprecated -- I think that it should probably extend the `DataDrivenImportJob` in the `org.apache.sqoop` package. Same thing for the imports in that class.
    
    I'll add a couple of other things I noticed as comments in the commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] sqoop issue #10: phoenix integration with 1.4.6

Posted by jqueguiner <gi...@git.apache.org>.

Github user jqueguiner commented on the issue:

    https://github.com/apache/sqoop/pull/10
  
    any update on this matter ?


---

[GitHub] sqoop pull request: phoenix integration with 1.4.6

Posted by jingwangfei <gi...@git.apache.org>.

Github user jingwangfei commented on the pull request:

    https://github.com/apache/sqoop/pull/10#issuecomment-199198979
  
    hi, gabrielreid .
    i don't know how can i get those code use git.....
    can you help me~
    thank you ~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---