You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/09/13 23:22:31 UTC
[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8061
Change subject: IMPALA-5905: build-all-flag-combinations addendum
......................................................................
IMPALA-5905: build-all-flag-combinations addendum
Running the script under Jenkins revealed a couple of issues that I'd
missed
Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/8061/1
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
......................................................................
IMPALA-5905: build-all-flag-combinations addendum
Running the script under Jenkins revealed a couple of issues that I'd
missed
Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Reviewed-on: http://gerrit.cloudera.org:8080/8061
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, but someone else must approve
Matthew Jacobs: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa97a981846a2397ecabb90b9039ba61c2c7af4e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No