[GitHub] [kafka] jwiederholdconfluent commented on a change in pull request #11758: MINOR: Clarify logging behavior with errors.log.include.messages property

[GitBox <gi...@apache.org>]

jwiederholdconfluent commented on a change in pull request #11758:
URL: https://github.com/apache/kafka/pull/11758#discussion_r808247925



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java
##########
@@ -150,9 +150,11 @@
     public static final String ERRORS_LOG_INCLUDE_MESSAGES_CONFIG = "errors.log.include.messages";
     public static final String ERRORS_LOG_INCLUDE_MESSAGES_DISPLAY = "Log Error Details";
     public static final boolean ERRORS_LOG_INCLUDE_MESSAGES_DEFAULT = false;
-    public static final String ERRORS_LOG_INCLUDE_MESSAGES_DOC = "Whether to the include in the log the Connect record that resulted in " +
-            "a failure. This is 'false' by default, which will prevent record keys, values, and headers from being written to log files, " +
-            "although some information such as topic and partition number will still be logged.";
+    public static final String ERRORS_LOG_INCLUDE_MESSAGES_DOC = "Whether to the include in the log the Connect record that resulted in a failure." +
+            "For sink records, the topic, partition, offset, and timestamp will be logged. " +
+            "For source records, the key and value (and their schemas), all headers, and the timestamp, Kafka topic, Kafka partition, source partition, " +

Review comment:
       The change looks good! Much more clear.
   One small thing... should "Whether to the include"  be "Whether to include"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org