[GitHub] [pinot] walterddr commented on a diff in pull request #10982: Allow extra aggregation types in RealtimeToOfflineSegmentsTask

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10982:
URL: https://github.com/apache/pinot/pull/10982#discussion_r1244327305


##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java:
##########
@@ -1755,6 +1755,14 @@ public void testTaskConfig() {
     } catch (IllegalStateException e) {
       Assert.assertTrue(e.getMessage().contains("has invalid aggregate type"));
     }
+
+    // valid agg
+    HashMap<String, String> validAggConfig = new HashMap<>(realtimeToOfflineTaskConfig);

Review Comment:
   could we also add a test for invalid agg please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org