You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/01/31 00:22:25 UTC

[GitHub] [beam] thiagotnunes opened a new pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

thiagotnunes opened a new pull request #16653:
URL: https://github.com/apache/beam/pull/16653


   Adds integration tests to test the SpannerIO.readChangeStreams functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1026353794


   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1028560953


   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1027308244


   closing and reopening to try to trigger tests on top of new changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1026719303


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1025271375


   R: @pabloem 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1031827460


   these all make sense to me. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1028629095


   note the runs from your new integration tests: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/920/testReport/org.apache.beam.sdk.io.gcp.spanner.changestreams.it/
   
   : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #16653:
URL: https://github.com/apache/beam/pull/16653


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem closed pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #16653:
URL: https://github.com/apache/beam/pull/16653


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1025271307


   Needs https://github.com/apache/beam/pull/16581 to be merged first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1034460882


   The tests are consistently failing on dataflow v1 and dataflow v2, I'm gonna sickbay them for now https://github.com/apache/beam/pull/16799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1026261417


   could you rebase this please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #16653: [BEAM-12164]: Add integration tests for spanner change streams

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on pull request #16653:
URL: https://github.com/apache/beam/pull/16653#issuecomment-1028639204


   Oh great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org