You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/12 16:24:57 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #29375: migrated some part of test always to pytest

potiuk commented on code in PR #29375:
URL: https://github.com/apache/airflow/pull/29375#discussion_r1103831108


##########
tests/always/test_project_structure.py:
##########
@@ -90,8 +89,10 @@ def test_providers_modules_should_have_tests(self):
 
         missing_tests_files = expected_test_files - expected_test_files.intersection(current_test_files)
 
-        with self.subTest("Detect missing tests in providers module"):
+        try:

Review Comment:
   Hmm. That looks strange. I am not sure if I understand why we have try/Except at all (assert with description should be enough) and I am not sure what was the effect of self.subTest here. Can you please explain @Abhishek-kumar-samsung ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org