You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/05 06:22:48 UTC

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

avijayanhwx opened a new pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529
 
 
   …with Auto TLS enabled.
   
   ## What changes were proposed in this pull request?
   Currently, Recon server crashes on a cluster with Auto TLS enabled due to CNF error while starting up its HTTP server. Recon's Httpserver is inherited from BaseHttpServer that is used by all the other components in Ozone. The underlying problem is being fixed in HDDS-2041. Since the other components like the SCM, OM start successfully even if their HTTP Server is not up, this patch relaxes the start for Recon as well. 
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-2982
   
   Please replace this section with the link to the Apache JIRA)
   
   ## How was this patch tested?
   Manually tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx closed pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

avijayanhwx closed pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

avijayanhwx commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529#issuecomment-582259958
 
 
   cc @swagle 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] mukul1987 commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

mukul1987 commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529#issuecomment-582560666
 
 
   @avijayanhwx there are some integration test failures. they do not seem related however can you please push an empty patch to re-trigger the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

avijayanhwx commented on a change in pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529#discussion_r375602903

##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
##########
@@ -82,7 +82,13 @@ protected void configureServlets() {
LOG.info("Creating Recon Schema.");
reconSchemaManager.createReconSchema();

- httpServer = injector.getInstance(ReconHttpServer.class);
+ // TODO Remove try-catch block after HDDS-2041 is fixed.
+ // Allowing Recon server start even if HTTP server start failed
+ try {

Review comment:
@bharatviswa504 Yes that is a valid question. On further investigation, I discovered that this may be due to jetty upgrade in hadoop in the distribution. This affects all Ozone components. Also, in the case of SCM, even though it withstands a HttpServer crash, since the initialization is stopped midway due to exception, none of the event handlers are registered thereby making the component useless.

I plan to hold on to this PR, wont commit it. If jetty version is indeed the problem, I will close this PR without merging the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on a change in pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529#discussion_r375598522
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
 ##########
 @@ -82,7 +82,13 @@ protected void configureServlets() {
       LOG.info("Creating Recon Schema.");
       reconSchemaManager.createReconSchema();
 
-      httpServer = injector.getInstance(ReconHttpServer.class);
+      // TODO Remove try-catch block after HDDS-2041 is fixed.
+      // Allowing Recon server start even if HTTP server start failed
+      try {
 
 Review comment:
   One question if HttpServer start failed will any functionality of recon works, like getContainers etc.,
   
   But whereas in OM SCM, core functionality still works even if HttpServer does not start. Not sure if I am missing something here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

adoroszlai commented on issue #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …
URL: https://github.com/apache/hadoop-ozone/pull/529#issuecomment-582564760
 
 
   > there are some integration test failures.
   
   Acceptance test failures are tracked in HDDS-2977 and HDDS-2983.  Please do not re-trigger until those are merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #529: HDDS-2982. Recon server start failed with CNF exception in a cluster …

Posted by GitBox <gi...@apache.org>.

- httpServer = injector.getInstance(ReconHttpServer.class);
+ // TODO Remove try-catch block after HDDS-2041 is fixed.
+ // Allowing Recon server start even if HTTP server start failed
+ try {

I plan to hold on to this PR, wont commit it. If jetty version is indeed the problem, that is being handled in HDDS-2950. I will close this PR without merging the changes.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services