You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 15:43:37 UTC

[GitHub] [spark] Kimahriman edited a comment on pull request #35085: [SPARK-37618][CORE] Remove shuffle blocks using the shuffle service for released executors

Kimahriman edited a comment on pull request #35085:
URL: https://github.com/apache/spark/pull/35085#issuecomment-1069248997


   > As in my comment below, I think title and description of issue and config need updated. We should not be releases shuffle files based one executor being released, Shuffle blocks should only be removed when they aren't needed and I think here its done by context cleaner. If there is something I'm missing please let me know.
   
   Everything is still based off the context cleaner, can update the config description to clarify
   
   > What all has this been tested on? it seems yarn secure env, has it been tested in standalone mode or in non-secure env or mesos (which our docs say we support but I know nothing about)?
   
   I only have a yarn env to test with so I can't verify on standalone or mesos. Non-secure should be a subset of secure so the permissions changes should just noops most likely. Anything running all as the same local user really.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org