You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by yh...@apache.org on 2023/07/28 13:04:44 UTC

[beam] branch master updated: refs: issue-27728, Improve java sdk docs (#27724)

This is an automated email from the ASF dual-hosted git repository.

yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new d966b6b95ae refs: issue-27728, Improve java sdk docs (#27724)
d966b6b95ae is described below

commit d966b6b95ae877a0801c3691d65bc0e3b7cc7bd8
Author: Laksh <la...@gmail.com>
AuthorDate: Fri Jul 28 09:04:31 2023 -0400

    refs: issue-27728, Improve java sdk docs (#27724)
    
    * Keep the docs consistent between SDKs
    
    * Update DatastoreV1.java
    
    * Update DatastoreV1.java
---
 .../main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
index f5a3d243e12..50fd977274d 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
@@ -648,8 +648,8 @@ public class DatastoreV1 {
      *       chosen dynamically at runtime based on the query data size.
      *   <li>Any value greater than {@link Read#NUM_QUERY_SPLITS_MAX} will be capped at {@code
      *       NUM_QUERY_SPLITS_MAX}.
-     *   <li>If the {@code query} has a user limit set, then {@code numQuerySplits} will be ignored
-     *       and no split will be performed.
+     *   <li>If the {@code query} has a user limit set, or contains inequality filters, then {@code
+     *       numQuerySplits} will be ignored and no split will be performed.
      *   <li>Under certain cases Cloud Datastore is unable to split query to the requested number of
      *       splits. In such cases we just use whatever the Cloud Datastore returns.
      * </ul>