You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/12 18:58:08 UTC

[GitHub] [commons-text] garydgregory commented on a change in pull request #190: added cp1252 escapes

garydgregory commented on a change in pull request #190:
URL: https://github.com/apache/commons-text/pull/190#discussion_r541729451



##########
File path: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
##########
@@ -49,12 +49,14 @@
     private static final String FOO = "foo";
 
     private static final String[][] HTML_ESCAPES = {
+            // message, expected, original
             {"no escaping", "plain text", "plain text"},
             {"no escaping", "plain text", "plain text"},
             {"empty string", "", ""},
             {"null", null, null},
             {"ampersand", "bread &amp; butter", "bread & butter"},
             {"quotes", "&quot;bread&quot; &amp; butter", "\"bread\" & butter"},
+            {"smart quotes", "&ldquo;bread and circuses&rdquo;", "\u201Cbread and circuses\u201d"},

Review comment:
       I see a new map with dozens of new entries but you are only testing a single value? Am I reading this right or are all the other map entries somehow also tested?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org