You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2014/06/23 19:46:30 UTC
svn commit: r1604892 - in /httpcomponents/httpclient/trunk:
httpclient-cache/src/test/java/org/apache/http/impl/client/cache/
httpclient/src/main/java/org/apache/http/impl/auth/
httpclient/src/test/java/org/apache/http/conn/ssl/
Author: sebb
Date: Mon Jun 23 17:46:29 2014
New Revision: 1604892
URL: http://svn.apache.org/r1604892
Log:
Add TODOs for code that needs looking at
Modified:
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java?rev=1604892&r1=1604891&r2=1604892&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java Mon Jun 23 17:46:29 2014
@@ -6049,7 +6049,7 @@ public class TestProtocolRequirements ex
// received-by
if (!Pattern.matches(tokenRegexp, parts[1])) {
// host : port
- new HttpHost(parts[1]);
+ new HttpHost(parts[1]); // TODO - unused - is this a test bug? else use Assert.assertNotNull
}
// comment
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java?rev=1604892&r1=1604891&r2=1604892&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java Mon Jun 23 17:46:29 2014
@@ -177,7 +177,7 @@ public class HttpAuthenticator {
final HttpContext context) throws HttpException, IOException {
AuthScheme authScheme = authState.getAuthScheme();
Credentials creds = authState.getCredentials();
- switch (authState.getState()) {
+ switch (authState.getState()) { // TODO add UNCHALLENGED and HANDSHAKE cases
case FAILURE:
return;
case SUCCESS:
Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java?rev=1604892&r1=1604891&r2=1604892&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java Mon Jun 23 17:46:29 2014
@@ -176,6 +176,7 @@ public class TestSSLSocketFactory {
@Test
public void testClientAuthSSLAliasChoice() throws Exception {
+ // TODO unused - is there a bug in the test?
final PrivateKeyStrategy aliasStrategy = new PrivateKeyStrategy() {
@Override