You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/07 13:13:44 UTC

[GitHub] [camel] essobedo opened a new pull request, #8678: CAMEL-17505: camel-core - Propose primitive types in builder methods

essobedo opened a new pull request, #8678:
URL: https://github.com/apache/camel/pull/8678

   Related to https://issues.apache.org/jira/browse/CAMEL-17505
   
   ## Motivation
   
   For primitive types like int, boolean and long, the builders propose only methods that accept a `String` as parameter, we need to overload those methods to propose more appropriate types in case of primitive types.
   
   ## Modifications:
   
   * Add a method with a more convenient parameter type for each parameter of a primitive type
   * Avoid setting unecessary default values to keep the code easy to read and maintain
   * Add the missing method `aliases` to `XStreamDataFormat`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8678: CAMEL-17505: camel-core - Propose primitive types in builder methods

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8678:
URL: https://github.com/apache/camel/pull/8678#issuecomment-1305682601

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo merged pull request #8678: CAMEL-17505: camel-core - Propose primitive types in builder methods

Posted by GitBox <gi...@apache.org>.
essobedo merged PR #8678:
URL: https://github.com/apache/camel/pull/8678


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8678: CAMEL-17505: camel-core - Propose primitive types in builder methods

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8678:
URL: https://github.com/apache/camel/pull/8678#issuecomment-1305704693

   The checkstyle issue is not related to those changes:
   ```
   Could not find artifact org.apache.camel:camel-snmp:jar:3.20.0-SNAPSHOT
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8678: CAMEL-17505: camel-core - Propose primitive types in builder methods

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8678:
URL: https://github.com/apache/camel/pull/8678#issuecomment-1305599754

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org