You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/11 14:18:45 UTC
[GitHub] [kafka] ijuma opened a new pull request, #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency
ijuma opened a new pull request, #12148:
URL: https://github.com/apache/kafka/pull/12148
* Remove `log4j-appender` dependency from `tools`, `trogdor` and `shell`
* Remove explicit `log4j` dependency from `trogdor` and `tools`.
* Add `compileOnly` dependency from `tools` to `log4j` (same approach as
`core`).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1279058422
@omkreddy Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1923774328
@ijuma can you rebase this PR? I think removing the unnecessary log4j-appender dependencies is still a good to have cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency
Posted by GitBox <gi...@apache.org>.
omkreddy commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1251901651
@ijuma sorry missed this. Can you rebase the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1156718290
@omkreddy maybe you can help review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1123834576
@cmccabe is there any reason why `shell` and `trogdor` need `log4j-appender`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org