You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/09/07 15:50:34 UTC
[GitHub] [flink] 1996fanrui opened a new pull request, #23372: [FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
1996fanrui opened a new pull request, #23372:
URL: https://github.com/apache/flink/pull/23372
## What is the purpose of the change
Currently, the flamegraph can be triggered when task is running.
After [FLINK-17012](https://issues.apache.org/jira/browse/FLINK-17012) and [FLINK-22215](https://issues.apache.org/jira/browse/FLINK-22215), flink split the running to running and initializing. We should allow trigger flamegraph when task is initializing. For example, the initialization is very slow, we need to troubleshoot.
## Brief change log
[FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
## Verifying this change
Added the `@Parameter public ExecutionState executionState;` for the `VertexThreadInfoTrackerTest`. And all tests will run with running and initializing.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23372: [FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23372:
URL: https://github.com/apache/flink/pull/23372#issuecomment-1710406803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a37a649a983c2f23d4de33ccac525bd9ead16bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a37a649a983c2f23d4de33ccac525bd9ead16bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a37a649a983c2f23d4de33ccac525bd9ead16bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui merged pull request #23372: [FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #23372:
URL: https://github.com/apache/flink/pull/23372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a diff in pull request #23372: [FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #23372:
URL: https://github.com/apache/flink/pull/23372#discussion_r1320564934
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html:
##########
@@ -16,8 +16,13 @@
~ limitations under the License.
-->
-<span *ngIf="selectedVertex?.detail?.status !== 'RUNNING'">
- Operator is not running. Cannot sample back pressure.
+<span
+ *ngIf="
+ selectedVertex?.detail?.status !== 'RUNNING' &&
+ selectedVertex?.detail?.status !== 'INITIALIZING'
+ "
+>
+ Operator is not running or initializing. Cannot sample flame graph.
Review Comment:
👍 nice~
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html:
##########
@@ -16,8 +16,13 @@
~ limitations under the License.
-->
-<span *ngIf="selectedVertex?.detail?.status !== 'RUNNING'">
- Operator is not running. Cannot sample back pressure.
+<span
+ *ngIf="
+ selectedVertex?.detail?.status !== 'RUNNING' &&
+ selectedVertex?.detail?.status !== 'INITIALIZING'
+ "
+>
+ Operator is not running or initializing. Cannot sample flame graph.
Review Comment:
👍 nice~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #23372: [FLINK-33042][flamegraph] Allow trigger flamegraph when task is initializing
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23372:
URL: https://github.com/apache/flink/pull/23372#issuecomment-1710983769
cc @RocMarshal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org