You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2026/07/29 07:26:09 UTC
[PR] [GH-3200] Serialize empty Geography LineStrings as valid WKB [sedona]
jiayuasu opened a new pull request, #3205:
URL: https://github.com/apache/sedona/pull/3205
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/).
## Is this PR related to a ticket?
- Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #3200.
## What changes were proposed in this PR?
- Write the required zero coordinate count when serializing an empty `SinglePolylineGeography`.
- Produce valid `LINESTRING EMPTY` WKB instead of a header-only, malformed byte sequence.
- Allow `WKBGeography.fromS2Geography()` to round-trip an empty LineString through JTS while preserving its SRID.
The malformed WKB was discovered while reviewing #3195. This PR isolates the pre-existing serialization defect from the `ST_MakeLine` feature. It does not define the separate behavior for `ST_MakeLine(EMPTY, non-empty)`, which is tracked by #3202.
## How was this patch tested?
- Full common module suite: 1,181 tests, 0 failures.
- Added an exact-WKB assertion for `010200000000000000`.
- Added WKB-to-S2 and S2-to-WKB-to-JTS empty LineString round-trip coverage.
- Formatting and commit hooks passed.
## Did this PR include necessary documentation updates?
- No. This corrects malformed internal serialization without changing the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-3200] Serialize empty Geography LineStrings as valid WKB [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #3205:
URL: https://github.com/apache/sedona/pull/3205#issuecomment-5121460327
Closing as superseded by #3195. The merged implementation now writes empty geography LineStrings as valid zero-coordinate WKB and also handles S2 singleton polylines by emitting an OGC-valid two-coordinate LineString, with round-trip coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-3200] Serialize empty Geography LineStrings as valid WKB [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu closed pull request #3205: [GH-3200] Serialize empty Geography LineStrings as valid WKB
URL: https://github.com/apache/sedona/pull/3205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org