You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2019/04/02 07:26:02 UTC
[GitHub] [incubator-plc4x] gg587998 commented on issue #56:
Feature/connection manager
gg587998 commented on issue #56: Feature/connection manager
URL: https://github.com/apache/incubator-plc4x/pull/56#issuecomment-478877265
in some cases this does not work, i did find the problem yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: AW: [GitHub] [incubator-plc4x] gg587998 commented on issue #56:
Feature/connection manager
Posted by Gunther Gruber <gu...@IDA-Analytics.de>.
Hi Julian,
thanks for merging in the code.
I even came up with a more simple and more stable approach to reconnect
the driver and fetch data continuously. It uses the exception thrown
when the get() method is invoked. I created another pull request
feature/example-pollLoop. I think it would be even possible to set a
custom timeout on the PlcConnectionException of the drivermanager.
Feel free to feedback me on my code.
Maybe some people will be interested in such an example - i am not shure.
On 02.04.19 09:35, Julian Feinauer wrote:
> Hi Gunter,
>
> Thanks for the pr.
> The code you sent via email is also merged in develop (plc4x-108). So if you like you can try it out and report if it works for you.
>
> Julian
>
> Von meinem Mobiltelefon gesendet
>
>
> -------- Ursprüngliche Nachricht --------
> Betreff: [GitHub] [incubator-plc4x] gg587998 commented on issue #56: Feature/connection manager
> Von: GitBox
> An: dev@plc4x.apache.org
> Cc:
>
> gg587998 commented on issue #56: Feature/connection manager
> URL: https://github.com/apache/incubator-plc4x/pull/56#issuecomment-478877265
>
>
> in some cases this does not work, i did find the problem yet
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
AW: [GitHub] [incubator-plc4x] gg587998 commented on issue #56:
Feature/connection manager
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Gunter,
Thanks for the pr.
The code you sent via email is also merged in develop (plc4x-108). So if you like you can try it out and report if it works for you.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: [GitHub] [incubator-plc4x] gg587998 commented on issue #56: Feature/connection manager
Von: GitBox
An: dev@plc4x.apache.org
Cc:
gg587998 commented on issue #56: Feature/connection manager
URL: https://github.com/apache/incubator-plc4x/pull/56#issuecomment-478877265
in some cases this does not work, i did find the problem yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services