[isis] branch ISIS-2553_rational.id created (now ff8bece)

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a change to branch ISIS-2553_rational.id
in repository https://gitbox.apache.org/repos/asf/isis.git.


      at ff8bece  ISIS-2553: place initial deprecation markers

This branch includes the following new commits:

     new ff8bece  ISIS-2553: place initial deprecation markers

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[isis] 01/01: ISIS-2553: place initial deprecation markers

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch ISIS-2553_rational.id
in repository https://gitbox.apache.org/repos/asf/isis.git

commit ff8bece8c65c31287c908310d90952efc3bb3347
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Mar 1 11:23:53 2021 +0100

    ISIS-2553: place initial deprecation markers
---
 api/applib/src/main/java/org/apache/isis/applib/Identifier.java        | 3 +++
 .../isis/core/metamodel/services/appfeat/ApplicationFeatureId.java     | 3 +++
 .../main/java/org/apache/isis/core/metamodel/spec/ObjectSpecId.java    | 2 ++
 3 files changed, 8 insertions(+)

diff --git a/api/applib/src/main/java/org/apache/isis/applib/Identifier.java b/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
index 87fd701..12e84ea 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
@@ -32,6 +32,9 @@ import lombok.NonNull;
 import lombok.val;
 
 /**
+ * //TODO[2553] needs to be made Serializable, so can act as replacement for ApplicationFeatureId 
+ * 
+ * 
  * Combines {@link TypeIdentifier} and member identification (from properties, collections or actions),
  * to a fully qualified <i>feature</i> identifier.
  * <p> 
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/appfeat/ApplicationFeatureId.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/appfeat/ApplicationFeatureId.java
index 1993ced..7ebd562 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/appfeat/ApplicationFeatureId.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/appfeat/ApplicationFeatureId.java
@@ -33,6 +33,7 @@ import static java.util.Comparator.nullsFirst;
 import org.apache.isis.applib.Identifier;
 import org.apache.isis.applib.annotation.Programmatic;
 import org.apache.isis.applib.annotation.Value;
+import org.apache.isis.applib.id.TypeIdentifier;
 import org.apache.isis.applib.services.appfeat.ApplicationMemberType;
 import org.apache.isis.applib.util.Equality;
 import org.apache.isis.applib.util.Hashing;
@@ -52,6 +53,8 @@ import lombok.val;
  * This value is {@link Comparable}, the implementation of which considers 
  * {@link #getType() (feature) type}, {@link #getNamespace() logical package name}, 
  * {@link #getTypeSimpleName() class name} and {@link #getMemberName() member name}.
+ * 
+ * @deprecated use {@link Identifier} instead  
  */
 @Value
 public class ApplicationFeatureId 
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecId.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecId.java
index 3057234..d64ffce 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecId.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecId.java
@@ -20,6 +20,7 @@ package org.apache.isis.core.metamodel.spec;
 
 import java.io.Serializable;
 
+import org.apache.isis.applib.id.TypeIdentifier;
 import org.apache.isis.commons.internal.base._Refs;
 import org.apache.isis.core.metamodel.facets.object.objectspecid.ObjectSpecIdFacet;
 
@@ -36,6 +37,7 @@ import lombok.Value;
  *
  * <p>
  * Has value semantics.
+ * @deprecated use {@link TypeIdentifier} instead
  */
 @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
 @Value