[GitHub] eiri commented on issue #1842: Implement partition size limits

[GitBox <gi...@apache.org>]

eiri commented on issue #1842: Implement partition size limits
URL: https://github.com/apache/couchdb/pull/1842#issuecomment-454567956
 
 
   @davisp Here is a thing - I see three corner cases where this approach is... not perfect.
   
   1) A bulk update that tips a partition over will insert all its docs anyway, because we gather `FullPartitions` before `merge_rev_trees` and the partition that was not already overflown is not going to be considered for a doc's size check.
   
   2) The ddocs can be inserted into overflown partition freely and there are some big ddocs out there. I believe this is what you've meant about not 100% happy, but to be honest I can't think of a clever way to do this better.
   
   3) The attachments written before the overflow check, so a rouge (or a malicious) client with an aggressive attachment's upload retry can really bloat a database.
   
   I don't see a good way to address any of these without really overcomplicated things, so this is just an awareness note to come along with my +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services