You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Tony Dong <to...@gmail.com> on 2016/01/03 16:24:22 UTC
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 3:24 p.m.)
Review request for Aurora, Stephan Erb and Bill Farner.
Summary (updated)
-----------------
Add jittering to TruncatedBinaryBackoff.
Repository: aurora
Description (updated)
-------
Add jittering to TruncatedBinaryBackoff.
Diffs
-----
commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
Diff: https://reviews.apache.org/r/41717/diff/
Testing
-------
Thanks,
Tony Dong
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112469
-----------------------------------------------------------
Ship it!
LGTM after Stephan's comment is addressed.
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java (line 53)
<https://reviews.apache.org/r/41717/#comment172922>
convention nit: `checkNotNull(random)`
- Bill Farner
On Jan. 3, 2016, 7:39 a.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 7:39 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112459
-----------------------------------------------------------
Master (4a9f2ff) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 3, 2016, 3:39 p.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 3:39 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Tony Dong <to...@gmail.com>.
> On Jan. 3, 2016, 5:55 p.m., Bill Farner wrote:
> > Doh! I'm ready to apply this, but i can't land the patch and give you credit on the commit log without access to your e-mail in ReviewBoard.
> >
> > Please go here: https://reviews.apache.org/account/preferences/#profile
> > and untick `Keep profile information private`
unchecked, Thanks!
- Tony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112470
-----------------------------------------------------------
On Jan. 3, 2016, 5:51 p.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 5:51 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112470
-----------------------------------------------------------
Doh! I'm ready to apply this, but i can't land the patch and give you credit on the commit log without access to your e-mail in ReviewBoard.
Please go here: https://reviews.apache.org/account/preferences/#profile
and untick `Keep profile information private`
- Bill Farner
On Jan. 3, 2016, 9:51 a.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 9:51 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Tony Dong <to...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 5:51 p.m.)
Review request for Aurora, Stephan Erb and Bill Farner.
Repository: aurora
Description
-------
Add jittering to TruncatedBinaryBackoff.
Diffs (updated)
-----
commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
Diff: https://reviews.apache.org/r/41717/diff/
Testing
-------
Thanks,
Tony Dong
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112462
-----------------------------------------------------------
Ship it!
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java (line 74)
<https://reviews.apache.org/r/41717/#comment172920>
Copy paste error here.
- Stephan Erb
On Jan. 3, 2016, 4:39 p.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 4:39 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Tony Dong <to...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 3:39 p.m.)
Review request for Aurora, Stephan Erb and Bill Farner.
Repository: aurora
Description
-------
Add jittering to TruncatedBinaryBackoff.
Diffs (updated)
-----
commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
Diff: https://reviews.apache.org/r/41717/diff/
Testing
-------
Thanks,
Tony Dong
Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112458
-----------------------------------------------------------
Master (4a9f2ff) is red with this patch.
./build-support/jenkins/build.sh
:buildSrc:check UP-TO-DATE
:buildSrc:build
:commons:assemble
:commons:licenseMain
Unknown file extension: commons/src/main/resources/org/apache/aurora/common/net/http/handlers/thrift.st
Unknown file extension: commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logconfig.st
:commons:licenseMain UP-TO-DATE
:commons:licenseTest
Unknown file extension: commons/src/test/resources/org/apache/aurora/common/util/templating/template.st
:commons:licenseTest UP-TO-DATE
:commons:license UP-TO-DATE
:commons:compileTestJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:commons:processTestResources
:commons:testClasses
:commons:test
org.apache.aurora.common.util.TruncatedBinaryBackoffTest > testCalculateBackoffStop FAILED
java.lang.AssertionError at TruncatedBinaryBackoffTest.java:96
197 tests completed, 1 failed
:commons:test FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':commons:test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 4 mins 45.575 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 3, 2016, 3:24 p.m., Tony Dong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 3:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add jittering to TruncatedBinaryBackoff.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380
>
> Diff: https://reviews.apache.org/r/41717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Dong
>
>