[jira] [Commented] (MESOS-3417) Log source address replicated log recieved broadcasts

["haosdent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742491#comment-14742491 ] 

haosdent commented on MESOS-3417:
---------------------------------

Add const UPID& from as recover params, so that could log the libprocess address in log.
{code}
diff --git a/src/log/replica.cpp b/src/log/replica.cpp
index 2bfcc3e..0019c89 100644
--- a/src/log/replica.cpp
+++ b/src/log/replica.cpp
@@ -111,7 +111,7 @@ private:
   void write(const WriteRequest& request);

   // Handles a request from a recover process.
-  void recover(const RecoverRequest& request);
+  void recover(const UPID& from, const RecoverRequest& request);
{code}

> Log source address replicated log recieved broadcasts
> -----------------------------------------------------
>
>                 Key: MESOS-3417
>                 URL: https://issues.apache.org/jira/browse/MESOS-3417
>             Project: Mesos
>          Issue Type: Improvement
>          Components: replicated log
>    Affects Versions: 0.23.0, 0.24.0
>         Environment: Mesos 0.23
>            Reporter: Cody Maloney
>            Priority: Minor
>              Labels: mesosphere, newbie
>
> Currently Mesos doesn't log what machine a replicated log status broadcast was recieved from:
> {code}
> Sep 11 21:41:14 master-01 mesos-master[15625]: I0911 21:41:14.320164 15637 replica.cpp:641] Replica in EMPTY status received a broadcasted recover request
> Sep 11 21:41:14 master-01 mesos-dns[15583]: I0911 21:41:14.321097   15583 detect.go:118] ignoring children-changed event, leader has not changed: /mesos
> Sep 11 21:41:14 master-01 mesos-master[15625]: I0911 21:41:14.353914 15639 replica.cpp:641] Replica in EMPTY status received a broadcasted recover request
> Sep 11 21:41:14 master-01 mesos-master[15625]: I0911 21:41:14.479132 15639 replica.cpp:641] Replica in EMPTY status received a broadcasted recover request
> {code}
> It would be really useful for debugging replicated log startup issues to have info about where the message came from (libprocess address, ip, or hostname) the message came from



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)