You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/21 07:41:34 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #15695: [broker]Fast return if ack cumulative illegal
AnonHxy opened a new pull request, #15695:
URL: https://github.com/apache/pulsar/pull/15695
### Motivation
* It should fast return if ack type is Cumulative with illegal `CommandAck`
### Modifications
* Return if `ack.getMessageIdsCount() != 1` or `Subscription.isIndividualAckMode(subType)`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15695: [fix][broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15695:
URL: https://github.com/apache/pulsar/pull/15695#issuecomment-1133951054
Add UT, PTAL @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15695: [fix][broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15695:
URL: https://github.com/apache/pulsar/pull/15695#issuecomment-1134193561
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15695: [fix][broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15695:
URL: https://github.com/apache/pulsar/pull/15695#issuecomment-1134082187
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15695: [fix][broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15695:
URL: https://github.com/apache/pulsar/pull/15695#issuecomment-1134101035
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #15695: [fix][broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15695:
URL: https://github.com/apache/pulsar/pull/15695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15695: [broker]Fast return if ack cumulative illegal
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15695:
URL: https://github.com/apache/pulsar/pull/15695#issuecomment-1133650786
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org