You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "lsm1 (via GitHub)" <gi...@apache.org> on 2023/02/15 03:51:36 UTC
[GitHub] [kyuubi] lsm1 opened a new pull request, #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
lsm1 opened a new pull request, #4333:
URL: https://github.com/apache/kyuubi/pull/4333
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close [#4305](https://github.com/apache/kyuubi/issues/4305)
### manual tests
```sql
bin/beeline -u jdbc:hive2://X:10009 -e "
--asd
select 1 as a
"
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1442025618
> @cfmcgrady, any solution? we should revert it if we can not fix it properly
I don't have any thoughts on this issue, maybe we should revert it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1441438302
sorry for wrongly locally testing before, this is a breaking change for submitting multi-line python snippets.
<details>
<summary>log</summary>
```
0: jdbc:hive2://192.168.205.128:10009/> for i in [1, 2, 3]:
. . . . . . . . . . . . . . . . . . . > print(i);
2023-02-23 17:26:12.280 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[d70621de-5a0b-4253-8f3f-a4c51cacc806]: PENDING_STATE -> RUNNING_STATE, statement:
for i in [1, 2, 3]:
print(i)
23/02/23 17:26:13 INFO ExecutePython: Processing anonymous's query[209c8f29-3e06-4ce6-9271-f2ce396741ba]: PENDING_STATE -> RUNNING_STATE, statement:
for i in [1, 2, 3]:
print(i)
23/02/23 17:26:13 INFO ExecutePython:
Spark application name: kyuubi_USER_SPARK_SQL_anonymous_default_f7512afe-f0b3-449e-bf45-164af364616b
application ID: local-1677144339509
application web UI: http://192.168.205.128:59896
master: local[*]
deploy mode: client
version: 3.3.1
Start time: 2023-02-23T17:25:37.933
User: anonymous
23/02/23 17:26:13 INFO DAGScheduler: Asked to cancel job group 209c8f29-3e06-4ce6-9271-f2ce396741ba
23/02/23 17:26:13 ERROR ExecutePython: Error operating ExecutePython: org.apache.kyuubi.KyuubiSQLException: Interpret error:
for i in [1, 2, 3]:
print(i)
Some(PythonResponse(execute_reply,PythonResponseContent(null,IndentationError,expected an indented block (<stdin>, line 2),List( File "<stdin>", line 2
, print(i)
, ^
, IndentationError: expected an indented block
),error)))
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.$anonfun$executePython$1(ExecutePython.scala:96)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.withLocalProperties(ExecutePython.scala:160)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.org$apache$kyuubi$engine$spark$operation$ExecutePython$$executePython(ExecutePython.scala:81)
at org.apache.kyuubi.engine.spark.operation.ExecutePython$$anon$1.run(ExecutePython.scala:111)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
org.apache.kyuubi.KyuubiSQLException: Interpret error:
for i in [1, 2, 3]:
print(i)
Some(PythonResponse(execute_reply,PythonResponseContent(null,IndentationError,expected an indented block (<stdin>, line 2),List( File "<stdin>", line 2
, print(i)
, ^
, IndentationError: expected an indented block
),error)))
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.$anonfun$executePython$1(ExecutePython.scala:96)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.withLocalProperties(ExecutePython.scala:160)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.org$apache$kyuubi$engine$spark$operation$ExecutePython$$executePython(ExecutePython.scala:81)
at org.apache.kyuubi.engine.spark.operation.ExecutePython$$anon$1.run(ExecutePython.scala:111)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
23/02/23 17:26:13 INFO ExecutePython: Processing anonymous's query[209c8f29-3e06-4ce6-9271-f2ce396741ba]: RUNNING_STATE -> ERROR_STATE, time taken: 0.01 seconds
2023-02-23 17:26:13.096 INFO org.apache.kyuubi.operation.ExecuteStatement: Query[d70621de-5a0b-4253-8f3f-a4c51cacc806] in ERROR_STATE
2023-02-23 17:26:13.103 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[d70621de-5a0b-4253-8f3f-a4c51cacc806]: RUNNING_STATE -> ERROR_STATE, time taken: 0.823 seconds
Error: org.apache.kyuubi.KyuubiSQLException: org.apache.kyuubi.KyuubiSQLException: Error operating ExecutePython: org.apache.kyuubi.KyuubiSQLException: Interpret error:
for i in [1, 2, 3]:
print(i)
Some(PythonResponse(execute_reply,PythonResponseContent(null,IndentationError,expected an indented block (<stdin>, line 2),List( File "<stdin>", line 2
, print(i)
, ^
, IndentationError: expected an indented block
),error)))
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.$anonfun$executePython$1(ExecutePython.scala:96)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.withLocalProperties(ExecutePython.scala:160)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.org$apache$kyuubi$engine$spark$operation$ExecutePython$$executePython(ExecutePython.scala:81)
at org.apache.kyuubi.engine.spark.operation.ExecutePython$$anon$1.run(ExecutePython.scala:111)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.engine.spark.operation.SparkOperation$$anonfun$onError$1.applyOrElse(SparkOperation.scala:188)
at org.apache.kyuubi.engine.spark.operation.SparkOperation$$anonfun$onError$1.applyOrElse(SparkOperation.scala:172)
at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:38)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.$anonfun$executePython$1(ExecutePython.scala:99)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.withLocalProperties(ExecutePython.scala:160)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.org$apache$kyuubi$engine$spark$operation$ExecutePython$$executePython(ExecutePython.scala:81)
at org.apache.kyuubi.engine.spark.operation.ExecutePython$$anon$1.run(ExecutePython.scala:111)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kyuubi.KyuubiSQLException: Interpret error:
for i in [1, 2, 3]:
print(i)
Some(PythonResponse(execute_reply,PythonResponseContent(null,IndentationError,expected an indented block (<stdin>, line 2),List( File "<stdin>", line 2
, print(i)
, ^
, IndentationError: expected an indented block
),error)))
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.engine.spark.operation.ExecutePython.$anonfun$executePython$1(ExecutePython.scala:96)
... 9 more
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.operation.ExecuteStatement.waitStatementComplete(ExecuteStatement.scala:129)
at org.apache.kyuubi.operation.ExecuteStatement.$anonfun$runInternal$1(ExecuteStatement.scala:161)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748) (state=,code=0)
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1430712666
Can you add some unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1432743886
test run multi-line python snippets with this change.
```
0: jdbc:hive2://192.168.206.48:10009/> for i in [1, 2, 3]:
. . . . . . . . . . . . . . . . . . .> print(i);
2023-02-16 17:00:50.824 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[1215c099-cf9a-4c42-80c1-5290a456b8ea]: PENDING_STATE -> RUNNING_STATE, statement:
for i in [1, 2, 3]:
print(i)
23/02/16 17:00:50 INFO ExecutePython: Processing anonymous's query[fdc19881-4918-47f3-8b39-c1e97d01269b]: PENDING_STATE -> RUNNING_STATE, statement:
for i in [1, 2, 3]:
print(i)
23/02/16 17:00:50 INFO ExecutePython:
Spark application name: kyuubi_USER_SPARK_SQL_anonymous_default_a5f44f5d-d3ec-49e1-a594-8b0460e9728d
application ID: local-1676537993814
application web UI: http://192.168.206.48:65528
master: local[*]
deploy mode: client
version: 3.3.1
Start time: 2023-02-16T16:59:50.066
User: anonymous
23/02/16 17:00:50 INFO ExecutePython: Processing anonymous's query[fdc19881-4918-47f3-8b39-c1e97d01269b]: RUNNING_STATE -> FINISHED_STATE, time taken: 0.002 seconds
2023-02-16 17:00:50.836 INFO org.apache.kyuubi.operation.ExecuteStatement: Query[1215c099-cf9a-4c42-80c1-5290a456b8ea] in FINISHED_STATE
2023-02-16 17:00:50.836 INFO org.apache.kyuubi.operation.ExecuteStatement: Processing anonymous's query[1215c099-cf9a-4c42-80c1-5290a456b8ea]: RUNNING_STATE -> FINISHED_STATE, time taken: 0.011 seconds
+---------+---------+--------+---------+------------+
| output | status | ename | evalue | traceback |
+---------+---------+--------+---------+------------+
| 1
2
3 | ok | | | [] |
+---------+---------+--------+---------+------------+
1 row selected (0.06 seconds)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1430761106
# [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4333](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4dc21a) into [master](https://codecov.io/gh/apache/kyuubi/commit/3b0137ae7840458cfed10e65de9a6841d8e26197?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b0137a) will **increase** coverage by `0.14%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #4333 +/- ##
============================================
+ Coverage 53.40% 53.55% +0.14%
Complexity 13 13
============================================
Files 560 562 +2
Lines 30569 30704 +135
Branches 4139 4142 +3
============================================
+ Hits 16326 16443 +117
- Misses 12706 12718 +12
- Partials 1537 1543 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/hive/beeline/KyuubiBeeLine.java](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtYmVlbGluZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGl2ZS9iZWVsaW5lL0t5dXViaUJlZUxpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/kyuubi/jdbc/hive/ClosedOrCancelledException.java](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9DbG9zZWRPckNhbmNlbGxlZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/util/RowSetUtils.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL1Jvd1NldFV0aWxzLnNjYWxh) | `26.08% <0.00%> (-57.25%)` | :arrow_down: |
| [...ache/kyuubi/sql/plan/trino/TrinoFeOperations.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zcWwvcGxhbi90cmluby9Ucmlub0ZlT3BlcmF0aW9ucy5zY2FsYQ==) | `39.13% <0.00%> (-3.73%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `80.00% <0.00%> (-2.67%)` | :arrow_down: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `75.82% <0.00%> (-1.65%)` | :arrow_down: |
| [...kyuubi/engine/spark/operation/SparkOperation.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | `76.31% <0.00%> (-0.40%)` | :arrow_down: |
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `79.26% <0.00%> (ø)` | |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `72.26% <0.00%> (ø)` | |
| [...ache/kyuubi/server/api/v1/OperationsResource.scala](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL09wZXJhdGlvbnNSZXNvdXJjZS5zY2FsYQ==) | `67.85% <0.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/kyuubi/pull/4333?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1431040252
How about ut for multi single-line comments?
`"--comment line 1 \n --comment line 2 \n show database;"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1431269595
Run `dev/reformat` to fix the code style violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1432489730
@cfmcgrady would you please check will this change breaks the pyspark case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1432746550
thanks, merging to master(v1.8.0)/branch-1.7(v1.7.0)/branch-1.6(v1.6.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1442793799
> sorry for wrongly locally testing before, this is a breaking change for submitting multi-line python snippets.
We can add this python UT later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady closed pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
URL: https://github.com/apache/kyuubi/pull/4333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1432527027
> @cfmcgrady would you please check will this change breaks the pyspark case?
I think this should be a breaking change to run python snippets. I will check when I have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4333: [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4333:
URL: https://github.com/apache/kyuubi/pull/4333#issuecomment-1441550450
@cfmcgrady, any solution? we should revert it if we can not fix it properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org