[GitHub] [inlong] EMsnap commented on a diff in pull request #5636: [INLONG-5633][DataProxy] Add statistical information to the HTTP source

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #5636:
URL: https://github.com/apache/inlong/pull/5636#discussion_r952072827


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/http/HttpBaseSource.java:
##########
@@ -48,64 +46,55 @@ public class HttpBaseSource extends AbstractSource implements EventDrivenSource,
     protected String attr;
     protected String messageHandlerName;
     protected boolean filterEmptyMsg;
-    protected CounterGroup counterGroup;
-    protected CounterGroupExt counterGroupExt;
     protected int maxConnections = Integer.MAX_VALUE;
     protected boolean customProcessor = false;
     protected Context context;
-    private int statIntervalSec;
-    private StatRunner statRunner;
-    private Thread statThread;
+    // statistic
+    protected MonitorIndex monitorIndex = null;
+    protected MonitorIndexExt monitorIndexExt = null;
+    private int statIntervalSec = 60;
+    private int maxMonitorCnt = 300000;

Review Comment:
   the default value is set already so no need to declare here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org