You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/04/11 15:56:47 UTC
[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1913: feat(services/oss): reuse allow_anonymous
suyanhanx commented on code in PR #1913:
URL: https://github.com/apache/incubator-opendal/pull/1913#discussion_r1163030780
##########
core/src/services/oss/core.rs:
##########
@@ -62,30 +64,41 @@ impl Debug for OssCore {
}
impl OssCore {
- async fn load_credential(&self) -> Result<AliyunCredential> {
+ async fn load_credential(&self) -> Result<Option<AliyunCredential>> {
+ if self.allow_anonymous {
Review Comment:
If deleted, then this prop is always in effect? A little confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org