You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:16:47 UTC
[GitHub] [beam] iemejia opened a new pull request #11613: [BEAM-9833] Fix yaml issues, sort labels and merge button as only strategy
iemejia opened a new pull request #11613:
URL: https://github.com/apache/beam/pull/11613
Issues reported by yamllint and some minor fixes. Also set merge button as the only strategy because we don't want to encourage (o even make possible the other two).
R: @pabloem
CC: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11613: [BEAM-9833] Fix .asf.yaml issues, sort labels and disable rebase button
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-628918098
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11613: [BEAM-9833] Fix yaml issues, sort labels and merge button as only strategy
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-624365589
I am ok with squashing if it creates extra commits, but it does not seem to be the case or does it create the additional extra merge commit? I just want to ensure we follow the rules.
Now if the goal is to change the rules maybe we should move the discussion to the ML.
Pinging @kennknowles who created our default policy (extra Merge commit) to see what he thinks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11613: [BEAM-9833] Fix yaml issues, sort labels and merge button as only strategy
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-624311669
I thought consensus was that we did want to encourage squash for those PRs with a huge pile of fixup commits (and otherwise no semantically meaningful commits).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11613: [BEAM-9833] Fix yaml issues, sort labels and merge button as only strategy
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-624363164
I think squash is used by many, and it facilitates receiving contributions without the extra round trip to the contributors. I think we need to discuss more before removing it. Wdyt @iemejia?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11613: [BEAM-9833] Fix .asf.yaml issues, sort labels and disable rebase button
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-628891422
Done the changes suggested by @robertwb let only rebase disabled. Can someone PTAL. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #11613: [BEAM-9833] Fix .asf.yaml issues, sort labels and disable rebase button
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #11613:
URL: https://github.com/apache/beam/pull/11613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11613: [BEAM-9833] Fix yaml issues, sort labels and merge button as only strategy
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11613:
URL: https://github.com/apache/beam/pull/11613#issuecomment-624353261
@robertwb Agree, a consensus that nobody respects :). In the case of this PR I set into the merge approach because we have only [three options](https://help.github.com/en/github/administering-a-repository/about-merge-methods-on-github) and the other two (squash and rebase) do not create the additional merge commit required by the [Beam committer guide](https://beam.apache.org/contribute/committer-guide/#merging-it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org