You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/20 08:45:53 UTC

[GitHub] [spark] wzhfy opened a new pull request #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

wzhfy opened a new pull request #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963
 
 
   ### What changes were proposed in this pull request?
   This is a backport for [pr#26908](https://github.com/apache/spark/pull/26908).
   It's an obvious bug: currently when analyzing partition stats, we use old table stats to compare with newly computed stats to decide whether it should update stats or not.
   
   ### Why are the changes needed?
   bug fix
   
   ### Does this PR introduce any user-facing change?
   no
   
   ### How was this patch tested?
   add new tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568194514
 
 
   **[Test build #115642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115642/testReport)** for PR 26963 at commit [`15de02c`](https://github.com/apache/spark/commit/15de02cc750f35916d3c0153bc9ed095a0cfc094).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567874837
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115611/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568323350
 
 
   Merged to branch-2.4.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567874837
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115611/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568195862
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115642/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568195739
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568181860
 
 
   **[Test build #115642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115642/testReport)** for PR 26963 at commit [`15de02c`](https://github.com/apache/spark/commit/15de02cc750f35916d3c0153bc9ed095a0cfc094).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568195739
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568181860
 
 
   **[Test build #115642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115642/testReport)** for PR 26963 at commit [`15de02c`](https://github.com/apache/spark/commit/15de02cc750f35916d3c0153bc9ed095a0cfc094).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567874832
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567845472
 
 
   **[Test build #115611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115611/testReport)** for PR 26963 at commit [`856dc9c`](https://github.com/apache/spark/commit/856dc9c69ac10499a8f7580c2810cf3a9960959e).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567874329
 
 
   **[Test build #115611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115611/testReport)** for PR 26963 at commit [`856dc9c`](https://github.com/apache/spark/commit/856dc9c69ac10499a8f7580c2810cf3a9960959e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-567874832
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568182164
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20441/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568182163
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568182163
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568182164
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20441/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26963: [SPARK-30269][SQL][2.4] Should use old partition stats to decide whether to update stats when analyzing partition
URL: https://github.com/apache/spark/pull/26963#issuecomment-568195862
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115642/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org