You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hugo-syn (via GitHub)" <gi...@apache.org> on 2023/12/27 11:57:24 UTC
[PR] fix: Fix typo [superset]
hugo-syn opened a new pull request, #26366:
URL: https://github.com/apache/superset/pull/26366
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Just fix some typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Fix several typos [superset]
Posted by "hugo-syn (via GitHub)" <gi...@apache.org>.
hugo-syn commented on code in PR #26366:
URL: https://github.com/apache/superset/pull/26366#discussion_r1439727541
##########
helm/superset/values.yaml:
##########
@@ -800,7 +800,7 @@ redis:
## docker registry secret names (list)
# pullSecrets: nil
##
- ## Configure persistance
+ ## Configure persistence
Review Comment:
I just bumped the version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Fix several typos [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #26366:
URL: https://github.com/apache/superset/pull/26366#discussion_r1439690119
##########
helm/superset/values.yaml:
##########
@@ -800,7 +800,7 @@ redis:
## docker registry secret names (list)
# pullSecrets: nil
##
- ## Configure persistance
+ ## Configure persistence
Review Comment:
@hugo-syn because you've edited the Helm chart configs you'll also have to bump the chart version (as indicated by the failing CI check):
```
✖︎ superset => (version: "0.11.2", path: "helm/superset") > chart version not ok. Needs a version bump!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Fix several typos [superset]
Posted by "hugo-syn (via GitHub)" <gi...@apache.org>.
hugo-syn closed pull request #26366: fix(docs): Fix several typos
URL: https://github.com/apache/superset/pull/26366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org