[geode] branch develop updated: GEODE-4832: Add FlakyTest category to CacheWriterGetOldValueIntegrationTest

[kl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

klund pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5bfccee  GEODE-4832: Add FlakyTest category to CacheWriterGetOldValueIntegrationTest
5bfccee is described below

commit 5bfccee21f8c7d9a1d77c8ee643d106eeecb6a20
Author: Kirk Lund <kl...@apache.org>
AuthorDate: Mon Mar 19 16:30:57 2018 -0700

    GEODE-4832: Add FlakyTest category to CacheWriterGetOldValueIntegrationTest
    
    Previously run IntegrationTest(s) is/are leaving behind a disk store
    in the current working directory which then causes this test to fail.
    This is intermittent because the test execution ordering is not always
    consistent.
---
 .../cache/CacheWriterGetOldValueIntegrationTest.java        | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/CacheWriterGetOldValueIntegrationTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/CacheWriterGetOldValueIntegrationTest.java
index 89ad618..392af3e 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/CacheWriterGetOldValueIntegrationTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/CacheWriterGetOldValueIntegrationTest.java
@@ -14,14 +14,14 @@
  */
 package org.apache.geode.internal.cache;
 
-import static org.assertj.core.api.Assertions.*;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 
-import org.apache.logging.log4j.Logger;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -36,11 +36,14 @@ import org.apache.geode.cache.EvictionAttributes;
 import org.apache.geode.cache.Region;
 import org.apache.geode.cache.RegionFactory;
 import org.apache.geode.cache.util.CacheWriterAdapter;
-import org.apache.geode.internal.cache.GemFireCacheImpl;
-import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.junit.categories.FlakyTest;
 import org.apache.geode.test.junit.categories.IntegrationTest;
 
-@Category(IntegrationTest.class)
+/**
+ * FlakyTest: GEODE-4832: Caused by prior IntegrationTest(s) leaving behind a disk store file in
+ * current working directory.
+ */
+@Category({IntegrationTest.class, FlakyTest.class})
 public class CacheWriterGetOldValueIntegrationTest {
 
   private GemFireCacheImpl cache = null;

-- 
To stop receiving notification emails like this one, please contact
klund@apache.org.