You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/12 06:39:00 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #6546: Fixed list networks in projects after setting network permissions
harikrishna-patnala opened a new pull request, #6546:
URL: https://github.com/apache/cloudstack/pull/6546
### Description
This PR fixes #6544 where it could not list networks in a project even after network permissions are set.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181559712
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r918827935
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
//add networks of subdomains
if (domainId == null) {
networksToReturn.addAll(listDomainLevelNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
Review Comment:
it looks no changes with this line ?
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
Review Comment:
@sureshanaparti
`skipProjectNetworks` should be considered only when list account-level networks.
for domain and shared network (by network permission), `skipProjectNetworks` parameter should be always `true` , because networks in return always belong to accounts (`system` account or other accounts).
this pr looks good to me.
##########
test/integration/component/test_network_permissions.py:
##########
@@ -758,3 +758,24 @@ def test_04_deploy_vm_for_other_user_and_test_vm_operations(self):
command = """self.reset_network_permission({apiclient}, self.user_network, expected=True)"""
self.exec_command("self.otheruser_apiclient", command, expected=False)
self.exec_command("self.user_apiclient", command, expected=True)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_05_list_networks_under_project(self):
+ """ Testing list networks under a project """
+ self.create_network_permission(self.apiclient, self.user_network, self.domain_admin, self.project, expected=True)
+ self.list_network(self.apiclient, self.domain_admin, self.user_network, self.project, None, expected=True)
+
+ self.remove_network_permission(self.apiclient, self.user_network, self.domain_admin, self.project, expected=True)
+ self.list_network(self.apiclient, self.domain_admin, self.user_network, self.project, None, expected=False)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_06_list_networks_under_account(self):
+ """ Testing list networks under an account """
+ self.create_network_permission(self.apiclient, self.user_network, self.domain_admin, None, expected=True)
Review Comment:
@harikrishna-patnala
would it be good to create network permission to `otheruser` (not `domain_admin`) as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198876521
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189833663
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195119703
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189841332
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189873677
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195055746
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198858612
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200288362
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189849397
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195118643
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195902432
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190566834
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r919986034
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
//add networks of subdomains
if (domainId == null) {
networksToReturn.addAll(listDomainLevelNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
Review Comment:
yes, seems indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189873494
> Appears like build failures @harikrishna-patnala
Failing at some unknown place to this PR
[ERROR] /jenkins/workspace/acs-centos8-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.17.1.0-SNAPSHOT/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolHelper.java:[188,21] error: cannot find symbol
[ERROR] symbol: method setConversionPattern(String)
Rebased the PR and running the package again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1196376626
<b>Trillian test result (tid-4549)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4549-kvm-centos7.zip
Smoke tests completed. 81 look OK, 20 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_ISO_usage | `Error` | 1.07 | test_usage.py
test_01_lb_usage | `Error` | 3.17 | test_usage.py
test_01_nat_usage | `Error` | 6.23 | test_usage.py
test_01_public_ip_usage | `Error` | 1.06 | test_usage.py
test_01_snapshot_usage | `Error` | 19.58 | test_usage.py
test_01_template_usage | `Error` | 18.53 | test_usage.py
test_01_vm_usage | `Error` | 131.68 | test_usage.py
test_01_volume_usage | `Error` | 126.86 | test_usage.py
test_01_vpn_usage | `Error` | 8.37 | test_usage.py
test_01_deployVMInSharedNetwork | `Error` | 65.81 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.06 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.13 | test_network.py
test_01_snapshot_root_disk | `Error` | 3.22 | test_snapshots.py
test_query_async_job_result | `Error` | 82.75 | test_async_job.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 1.23 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.06 | test_direct_download.py
test_revoke_certificate | `Error` | 0.02 | test_certauthority_root.py
login_test_saml_user | `Error` | 2.50 | test_login.py
test_01_positive_tests_usage | `Error` | 7.84 | test_usage_events.py
test_role_account_acls_multiple_mgmt_servers | `Error` | 1.97 | test_dynamicroles.py
test_01_deploy_vms_storage_tags | `Error` | 13.67 | test_primary_storage.py
test_01_deploy_vms_storage_tags | `Error` | 13.68 | test_primary_storage.py
test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
ContextSuite context=TestStorageTags>:teardown | `Error` | 272.76 | test_primary_storage.py
test_01_vpc_privategw_acl | `Error` | 103.92 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Error` | 302.70 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 291.21 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Error` | 525.74 | test_privategw_acl.py
test_01_vpc_privategw_acl | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 0.01 | test_privategw_acl_ovs_gre.py
test_05_vpc_privategw_check_interface | `Error` | 0.01 | test_privategw_acl_ovs_gre.py
test_oobm_background_powerstate_sync | `Failure` | 20.53 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | `Error` | 20.54 | test_outofbandmanagement.py
test_oobm_configure_default_driver | `Error` | 0.04 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | `Error` | 0.04 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | `Error` | 0.06 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | `Error` | 1.12 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | `Error` | 0.07 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | `Error` | 1.10 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 8.62 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 8.62 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 4.37 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 4.37 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 2.24 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 2.24 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 1.24 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 1.24 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 2.26 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 2.26 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 3.27 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 3.27 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Error` | 1.11 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Error` | 1.11 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 1.16 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 1.16 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 1.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_cycle | `Error` | 1.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off | `Error` | 2.19 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off | `Error` | 2.19 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on | `Error` | 1.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on | `Error` | 1.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset | `Error` | 1.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset | `Error` | 1.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft | `Error` | 1.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft | `Error` | 1.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status | `Error` | 0.14 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status | `Error` | 0.14 | test_outofbandmanagement_nestedplugin.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 194.92 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 199.56 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 82.69 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.23 | test_kubernetes_supported_versions.py
test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py
test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
test_CreateTemplateWithDuplicateName | `Error` | 20.65 | test_templates.py
test_01_register_template_direct_download_flag | `Error` | 0.19 | test_templates.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 622.14 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_configure_default_driver | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_kvm_host_degraded | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 0.03 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 0.03 | test_hostha_kvm.py
test_remove_ha_provider_not_possible | `Error` | 0.04 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198858105
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195901699
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200112394
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181389837
@bluorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r918773723
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
Review Comment:
@weizhouapache is it ok to skip the project networks in all these cases? can you check and confirm when the project networks can be skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181559249
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r925169901
##########
test/integration/component/test_network_permissions.py:
##########
@@ -758,3 +758,24 @@ def test_04_deploy_vm_for_other_user_and_test_vm_operations(self):
command = """self.reset_network_permission({apiclient}, self.user_network, expected=True)"""
self.exec_command("self.otheruser_apiclient", command, expected=False)
self.exec_command("self.user_apiclient", command, expected=True)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_05_list_networks_under_project(self):
+ """ Testing list networks under a project """
+ self.create_network_permission(self.apiclient, self.user_network, self.domain_admin, self.project, expected=True)
+ self.list_network(self.apiclient, self.domain_admin, self.user_network, self.project, None, expected=True)
+
+ self.remove_network_permission(self.apiclient, self.user_network, self.domain_admin, self.project, expected=True)
+ self.list_network(self.apiclient, self.domain_admin, self.user_network, self.project, None, expected=False)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_06_list_networks_under_account(self):
+ """ Testing list networks under an account """
+ self.create_network_permission(self.apiclient, self.user_network, self.domain_admin, None, expected=True)
Review Comment:
added few more checks in the same test case @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189825248
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190177520
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6546)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190171709
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1196485623
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200111789
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181422342
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181982170
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181594122
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1191020467
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190129062
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195054943
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198882213
<b>Trillian Build Failed (tid-4561)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200112524
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189866754
Appears like build failures @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189889989
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190116429
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189829633
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6546 (SL-JID-1986)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190115641
@harikrishna-patnala can you merge latest 4.17 branch and try again?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190129784
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1196542346
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189825055
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189874349
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200112718
<b>Trillian Build Failed (tid-4576)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200107180
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198863518
<b>Trillian Build Failed (tid-4560)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1198876857
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1196484306
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200385451
<b>Trillian test result (tid-4579)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42930 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4579-vmware-67u3.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r919893745
##########
test/integration/component/test_network_permissions.py:
##########
@@ -758,3 +758,24 @@ def test_04_deploy_vm_for_other_user_and_test_vm_operations(self):
command = """self.reset_network_permission({apiclient}, self.user_network, expected=True)"""
self.exec_command("self.otheruser_apiclient", command, expected=False)
self.exec_command("self.user_apiclient", command, expected=True)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_05_list_networks_under_project(self):
Review Comment:
- is this test run against simulator (check travis yml)
- if not, can we move some sort of quick validation tests to smoke/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r919986945
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
Review Comment:
thanks for confirming it @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181603007
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6546)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1191709736
<b>Trillian test result (tid-4526)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4526-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 682.32 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 472.25 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195875265
<b>Trillian test result (tid-4544)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4544-kvm-centos7.zip
Smoke tests completed. 83 look OK, 18 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_ISO_usage | `Error` | 1.07 | test_usage.py
test_01_lb_usage | `Error` | 3.17 | test_usage.py
test_01_nat_usage | `Error` | 6.21 | test_usage.py
test_01_public_ip_usage | `Error` | 1.06 | test_usage.py
test_01_snapshot_usage | `Error` | 20.52 | test_usage.py
test_01_template_usage | `Error` | 9.34 | test_usage.py
test_01_vm_usage | `Error` | 133.50 | test_usage.py
test_01_volume_usage | `Error` | 125.85 | test_usage.py
test_01_vpn_usage | `Error` | 8.36 | test_usage.py
test_01_deployVMInSharedNetwork | `Error` | 63.81 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.05 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.13 | test_network.py
test_01_snapshot_root_disk | `Error` | 4.25 | test_snapshots.py
test_query_async_job_result | `Error` | 82.78 | test_async_job.py
test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
login_test_saml_user | `Error` | 2.46 | test_login.py
test_01_positive_tests_usage | `Error` | 7.87 | test_usage_events.py
test_role_account_acls_multiple_mgmt_servers | `Error` | 1.91 | test_dynamicroles.py
test_02_edit_primary_storage_tags | `Error` | 0.02 | test_primary_storage.py
test_01_vpc_privategw_acl | `Error` | 101.84 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Error` | 302.01 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 297.46 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Error` | 528.51 | test_privategw_acl.py
test_01_vpc_privategw_acl | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
test_05_vpc_privategw_check_interface | `Error` | 0.01 | test_privategw_acl_ovs_gre.py
test_oobm_background_powerstate_sync | `Failure` | 21.47 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | `Error` | 21.47 | test_outofbandmanagement.py
test_oobm_configure_default_driver | `Error` | 0.04 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | `Error` | 0.04 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | `Error` | 0.05 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | `Error` | 1.11 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | `Error` | 0.05 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | `Error` | 1.09 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 5.53 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 5.53 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 2.22 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 2.22 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 4.24 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 4.24 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 4.24 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 4.24 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 4.24 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 4.25 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Error` | 1.11 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Error` | 1.11 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 1.14 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 1.14 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 1.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_cycle | `Error` | 1.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off | `Error` | 2.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off | `Error` | 2.16 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on | `Error` | 2.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on | `Error` | 2.18 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset | `Error` | 2.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset | `Error` | 2.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft | `Error` | 2.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft | `Error` | 2.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status | `Error` | 1.17 | test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status | `Error` | 1.18 | test_outofbandmanagement_nestedplugin.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 204.09 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 225.89 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 84.78 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.21 | test_kubernetes_supported_versions.py
test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py
test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
test_CreateTemplateWithDuplicateName | `Error` | 19.61 | test_templates.py
test_01_register_template_direct_download_flag | `Error` | 0.13 | test_templates.py
test_disable_oobm_ha_state_ineligible | `Error` | 0.05 | test_hostha_kvm.py
test_hostha_configure_default_driver | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled | `Error` | 0.05 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_kvm_host_degraded | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 0.04 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 0.04 | test_hostha_kvm.py
test_remove_ha_provider_not_possible | `Error` | 0.03 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200107267
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200113993
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1182747224
<b>Trillian test result (tid-4499)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41401 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4499-kvm-centos7.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 461.68 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181391116
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200293158
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r925143875
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2035,23 +2035,23 @@ public Pair<List<? extends Network>, Integer> searchForNetworks(ListNetworksCmd
if (Arrays.asList(Network.NetworkFilter.Domain, Network.NetworkFilter.AccountDomain, Network.NetworkFilter.All).contains(networkFilter)) {
//add domain specific networks of domain + parent domains
networksToReturn.addAll(listDomainSpecificNetworksByDomainPath(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, skipProjectNetworks, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, path, isRecursive));
//add networks of subdomains
if (domainId == null) {
networksToReturn.addAll(listDomainLevelNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
- aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
+ aclType, true, restartRequired, specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, caller.getDomainId(), true));
Review Comment:
yes, its just indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189841543
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190535714
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190535029
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200113832
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200278249
<b>Trillian test result (tid-4577)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38148 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6546-t4577-vmware-67u3.zip
Smoke tests completed. 98 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup | `Error` | 41.48 | test_affinity_groups.py
test_DeployVmAntiAffinityGroup_in_project | `Error` | 95.84 | test_affinity_groups_projects.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 34.99 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200293256
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1200287955
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#discussion_r925169683
##########
test/integration/component/test_network_permissions.py:
##########
@@ -758,3 +758,24 @@ def test_04_deploy_vm_for_other_user_and_test_vm_operations(self):
command = """self.reset_network_permission({apiclient}, self.user_network, expected=True)"""
self.exec_command("self.otheruser_apiclient", command, expected=False)
self.exec_command("self.user_apiclient", command, expected=True)
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_05_list_networks_under_project(self):
Review Comment:
Moved this to smoke tests, I see some tests require hardware.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189825230
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1189825702
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1191020628
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1191344138
@harikrishna-patnala can you look at the travis failrue ?
```
2022-07-20 12:46:53,365 - CRITICAL - EXCEPTION: Failure:: ['Traceback (most recent call last):\n', ' File "/opt/pyenv/versions/3.6/lib/python3.6/unittest/case.py", line 59, in testPartExecutor\n yield\n', ' File "/opt/pyenv/versions/3.6/lib/python3.6/unittest/case.py", line 605, in run\n testMethod()\n', ' File "/home/travis/.local/lib/python3.6/site-packages/nose/failure.py", line 39, in runTest\n raise self.exc_val.with_traceback(self.tb)\n', ' File "/home/travis/.local/lib/python3.6/site-packages/nose/loader.py", line 418, in loadTestsFromName\n addr.filename, addr.module)\n', ' File "/home/travis/.local/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath\n return self.importFromDir(dir_path, fqname)\n', ' File "/home/travis/.local/lib/python3.6/site-packages/nose/importer.py", line 79, in importFromDir\n fh, filename, desc = find_module(part, path)\n', ' File "/opt/pyenv/versions/3.6/lib/python3.6/imp.py", line 297, in find_module
\n raise ImportError(_ERR_MSG.format(name), name=name)\n', "ImportError: No module named 'test_network_permissions'\n"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1190147148
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195085290
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1195120658
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6546)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6546&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6546&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6546&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6546: Fixed list networks in projects after setting network permissions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6546:
URL: https://github.com/apache/cloudstack/pull/6546#issuecomment-1181982841
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org