You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/14 10:17:04 UTC

[GitHub] [cloudstack] ravening opened a new pull request #5207: Display all project resources for ROOT admin in default view

ravening opened a new pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207


   ### Description
   
   Currently for ROOT admin, all the project resources are displayed
   only under the resprctive project view. It is handy to display
   all project resources of all subdomains under default view for
   ROOT admin
   
   Also display domain name in the instances overview
   
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   ![Screenshot 2021-07-14 at 12 16 33](https://user-images.githubusercontent.com/10645273/125605617-10bc5a57-636f-47b5-ab6f-816f784c1509.png)
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-879864060


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mib1185 edited a comment on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

mib1185 edited a comment on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-882115069


   Maybe this will make #4828 no longer needed 🤔 
   
   cc @DK101010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening closed pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

ravening closed pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mib1185 commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

mib1185 commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-882115069


   Maybe this will make #4828 no longer needed 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

ravening commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-1011906492


   closing this pr as the backend functionality already exists and ui functionality is added in #4828 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

Pearl1594 commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-879864401


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

Pearl1594 commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-879846808


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

ravening commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-882314093


   > > Currently for ROOT admin, all the project resources are displayed
   > > only under the resprctive project view. It is handy to display
   > > all project resources of all subdomains under default view for
   > > ROOT admin
   > 
   > @ravening , i can see why you want this, but it is a functional change and I would have it guarded by a setting or a parameter, either of which defaults to the old behaviour.
   
   @DaanHoogland i can add a global setting for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-881239443


   > Currently for ROOT admin, all the project resources are displayed
   > only under the resprctive project view. It is handy to display
   > all project resources of all subdomains under default view for
   > ROOT admin
   
   @ravening , i can see why you want this, but it is a functional change and I would have it guarded by a setting or a parameter, either of which defaults to the old behaviour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mib1185 edited a comment on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

mib1185 edited a comment on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-882115069


   Maybe this will make #4828 no longer needed 🤔 
   
   cc @DK101010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-880397231


   <b>Trillian test result (tid-1274)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 57196 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5207-t1274-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 79 look OK, 9 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_ping_in_cpvm_success | `Failure` | 14.31 | test_diagnostics.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 336.37 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 342.83 | test_routers_network_ops.py
   test_04_extract_template | `Failure` | 128.38 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_volume_usage | `Error` | 186.53 | test_usage.py
   test_10_attachAndDetach_iso | `Failure` | 1514.65 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 425.77 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 678.76 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mib1185 commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

mib1185 commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-920267476


   @PaulAngus had a good point with https://github.com/apache/cloudstack/pull/4828#issuecomment-919990854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-879847312


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

GutoVeronezi commented on a change in pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#discussion_r677740484



##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -2696,6 +2696,13 @@ public void buildACLSearchParameters(Account caller, Long id, String accountName
             if (id == null) {
                 domainIdRecursiveListProject.third(Project.ListProjectResourcesCriteria.SkipProjectResources);
             }
+
+            if ((caller.getType() == Account.ACCOUNT_TYPE_ADMIN) ||
+                    (caller.getType() == Account.ACCOUNT_TYPE_DOMAIN_ADMIN) ||
+                    (caller.getType() == Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN) ||
+                    (caller.getType() == Account.ACCOUNT_TYPE_READ_ONLY_ADMIN)) {

Review comment:
       We could extract all this enums to a constant list and verify if it contains the caller.getType.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mib1185 edited a comment on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

mib1185 edited a comment on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-882115069


   Maybe this will make #4828 no longer needed 🤔 
   
   cc @DK101010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5207: Display all project resources for ROOT admin in default view

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #5207:
URL: https://github.com/apache/cloudstack/pull/5207#issuecomment-879864587


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org