You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Luc Maisonobe <Lu...@free.fr> on 2012/04/07 11:41:21 UTC

[codec][collections][math]Re: [lang] adding an implementation of the Myers difference algorithm

Hi Gary,

Le 07/04/2012 04:30, Gary Gregory a écrit :
> On Apr 6, 2012, at 16:05, Luc Maisonobe <Lu...@free.fr> wrote:
> 
>> Hi Gary,
>>
>> Le 06/04/2012 21:50, Gary Gregory a écrit :
>>> On Fri, Apr 6, 2012 at 11:14 AM, luc <lu...@spaceroots.org> wrote:
>>>
>>>> Hello,
>>>>
>>>> Some times ago, Thomas proposed an implementation of a Longest Commons
>>>> Substring algorithm. At
>>>> that time I said I had another algorithm in the same spirit for the Myers
>>>> difference algorithm.
>>>>
>>>> I got the green light to provide this code base to the Apache Software
>>>> Foundation. I will send
>>>> the Software Grant to secretary in a few minutes. Once the grant is
>>>> registered, I will create a
>>>> Jira issue and attach the original code to it, then I will port it for
>>>> inclusion into Commons.
>>>>
>>>> The public API of this implementation takes two sequences of Object and
>>>> provides as output an EditScript
>>>> which implements the visitor design pattern. By visiting the script, we
>>>> can retrieve the differences
>>>> between the two sequences (objects inserted, object deleted) or we can
>>>> retrieve the similarities
>>>> (sub-sequences that are in both initial sequences). We only use the
>>>> "equals" method in the initial objects.
>>>>
>>>> So my questions are:
>>>>
>>>> - in which component do we include this, we talked about [lang], is it
>>>> right ?
>>>> - the classes are in a "comparator" package, where should we put this
>>>> package ?
>>>>
>>>
>>> .text?
>>
>> Perhaps, but it is much more general than that. It can be used on any
>> object as it only relies on equal. You could use it on text, on numbers,
>> on genetic sequences, on binary streams, you name it.
> 
> Not to be downer here but this is feeling out of scope for Lang. I

You are right.

> think about the java.lang extension mission and this does not fit IMO.
> So the next question is where in Commons would this fit? Codec? A new
> component? There are 20 plus components in Commons, let's think of the
> best fit.

Looking at the list, I would put [collections] as first choice and
[codec] as second choice ... and [math] as third choice (but this is
already stretching too far).

Any other idea or advice ?

Luc

> 
> Gary
> 
>>
>> Luc
>>
>>>
>>> Gary
>>>
>>>>
>>>> best regards,
>>>> Luc
>>>>
>>>> ------------------------------**------------------------------**---------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<de...@commons.apache.org>
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [codec][collections][math]Re: [lang] adding an implementation of the Myers difference algorithm

Posted by James Carman <jc...@carmanconsulting.com>.
I can see a simpler string-based version as being applicable to StringUtils
(char sequence)
On Apr 7, 2012 5:41 AM, "Luc Maisonobe" <Lu...@free.fr> wrote:

> Hi Gary,
>
> Le 07/04/2012 04:30, Gary Gregory a écrit :
> > On Apr 6, 2012, at 16:05, Luc Maisonobe <Lu...@free.fr> wrote:
> >
> >> Hi Gary,
> >>
> >> Le 06/04/2012 21:50, Gary Gregory a écrit :
> >>> On Fri, Apr 6, 2012 at 11:14 AM, luc <lu...@spaceroots.org> wrote:
> >>>
> >>>> Hello,
> >>>>
> >>>> Some times ago, Thomas proposed an implementation of a Longest Commons
> >>>> Substring algorithm. At
> >>>> that time I said I had another algorithm in the same spirit for the
> Myers
> >>>> difference algorithm.
> >>>>
> >>>> I got the green light to provide this code base to the Apache Software
> >>>> Foundation. I will send
> >>>> the Software Grant to secretary in a few minutes. Once the grant is
> >>>> registered, I will create a
> >>>> Jira issue and attach the original code to it, then I will port it for
> >>>> inclusion into Commons.
> >>>>
> >>>> The public API of this implementation takes two sequences of Object
> and
> >>>> provides as output an EditScript
> >>>> which implements the visitor design pattern. By visiting the script,
> we
> >>>> can retrieve the differences
> >>>> between the two sequences (objects inserted, object deleted) or we can
> >>>> retrieve the similarities
> >>>> (sub-sequences that are in both initial sequences). We only use the
> >>>> "equals" method in the initial objects.
> >>>>
> >>>> So my questions are:
> >>>>
> >>>> - in which component do we include this, we talked about [lang], is it
> >>>> right ?
> >>>> - the classes are in a "comparator" package, where should we put this
> >>>> package ?
> >>>>
> >>>
> >>> .text?
> >>
> >> Perhaps, but it is much more general than that. It can be used on any
> >> object as it only relies on equal. You could use it on text, on numbers,
> >> on genetic sequences, on binary streams, you name it.
> >
> > Not to be downer here but this is feeling out of scope for Lang. I
>
> You are right.
>
> > think about the java.lang extension mission and this does not fit IMO.
> > So the next question is where in Commons would this fit? Codec? A new
> > component? There are 20 plus components in Commons, let's think of the
> > best fit.
>
> Looking at the list, I would put [collections] as first choice and
> [codec] as second choice ... and [math] as third choice (but this is
> already stretching too far).
>
> Any other idea or advice ?
>
> Luc
>
> >
> > Gary
> >
> >>
> >> Luc
> >>
> >>>
> >>> Gary
> >>>
> >>>>
> >>>> best regards,
> >>>> Luc
> >>>>
> >>>>
> ------------------------------**------------------------------**---------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<
> dev-unsubscribe@commons.apache.org>
> >>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>
> >>>>
> >>>
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>